AbstractFolder.reloadThis
& .addLoadedChild
#378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CloudBees CI running in high availability mode we need to synchronize various
Item
s from disk. Handling simple items likeJob
s is straightforward enough: whenconfig.xml
changes on disk, reload it. (jenkinsci/jenkins#8544 makes this cleaner and more explicit.) But folders are more complicated:Folder
is created, there is an existing method to add it in memory.ComputedFolder
is created, there was no way to insert it into the child list in memory.Both new methods are exercised by functional tests in CloudBees CI. I am not sure if some OSS tools would find these useful. JCasC does not cover
Item
s.job-dsl
does, but does not deal with configuration on disk. The relevant scenario is that a tool creates, modifies, and deletes$JENKINS_HOME/jobs/**/config.xml
and then tries to reflect those changes in a running controller process with minimal disruption and overhead.