Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin parent POM #163

Merged
merged 3 commits into from
Apr 24, 2022
Merged

Update plugin parent POM #163

merged 3 commits into from
Apr 24, 2022

Conversation

basil
Copy link
Member

@basil basil commented Apr 23, 2022

I have been attempting to run PCT tests in jenkinsci/bom against Java 17 and newer versions of PCT, and this plugin is running into failures because its parent POM is too old. This PR updates the parent POM to the latest build toolchain from jenkinsci/analysis-pom-plugin#446 to facilitate Java 17 compatibility testing and PCT updates in jenkinsci/bom.

@basil
Copy link
Member Author

basil commented Apr 23, 2022

The GitHub Actions failures here are not my fault, as this plugin uses a version of Checkstyle that requires Java 11 but has GitHub Actions configured to run with Java 8.

@basil
Copy link
Member Author

basil commented Apr 23, 2022

jenkinsci/analysis-pom-plugin#420 should be reverted.

@uhafner
Copy link
Member

uhafner commented Apr 24, 2022

I think we should move to JDK11 when building the plugins. I converted all of my active plugins (that depend on analysis-pom) to use JDK 11 quite some time ago.

@basil
Copy link
Member Author

basil commented Apr 24, 2022

Done in commit 84b9587

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #163 (a801f67) into master (8b8b9c7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #163   +/-   ##
=========================================
  Coverage     85.38%   85.38%           
  Complexity      152      152           
=========================================
  Files            17       17           
  Lines           746      746           
  Branches         57       57           
=========================================
  Hits            637      637           
  Misses           89       89           
  Partials         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b8b9c7...a801f67. Read the comment docs.

@basil
Copy link
Member Author

basil commented Apr 24, 2022

Build is now green.

@timja timja merged commit 0368266 into jenkinsci:master Apr 24, 2022
@basil basil deleted the pom branch April 24, 2022 18:02
@basil
Copy link
Member Author

basil commented Apr 24, 2022

Thank you! A release of this would facilitate Java 17 PCT testing.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants