Modernize to latest versions supported by Java 8 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePluginForJava8?organizationId=SmVua2lucyBDSQ%3D%3D Co-authored-by: Moderne <[email protected]>
Unforking XStream required the access level of this method to be protected. Fortunately this means the super method can be called directly instead of using reflection. jenkinsci/jenkins#4944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR aims to modernize tooling and move this plugin closer to the recommended Jenkins baseline version without making the change too big. If this goes well, I can follow up with a subsequent PR to modernize further.
This PR was generated with an OpenRewrite recipe on Moderne.io.
Testing done
Ran
mvn clean verify. Compilation failed before changingreadResolvetoprotected.Submitter checklist