Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Japanese translations #63

Merged
merged 3 commits into from
Oct 5, 2017

Conversation

ikedam
Copy link
Member

@ikedam ikedam commented Jan 28, 2017

Additional changes for #62.

  • Revert removed comments.
  • Add comments for the review.
  • Fix trivial errors.

@ikedam ikedam changed the title Japanes translation (updtes #62) Japanes translation (updates #62) Jan 28, 2017
@@ -1,6 +1,6 @@
# The MIT License
#
# Copyright (c) 2004-2012, Sun Microsystems, Inc., Seiji Sogabe
# Copyright (c) 2016-, Seiji Sogabe
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this file is displayed as renamed, they are actually not renamed but removed and added.
LikelyStuckTimeOutStrategy/config.jelly have no texts to translate (there are no text "Likely stuck"), and LikelyStuckTimeOutStrategy/config_ja.properties is unnecessary.

Timeout.Failed=\u5931\u6557

#BuildStepWithTimeout.DisplayName=タイムアウト付きの実行
BuildStepWithTimeout.DisplayName=\u30bf\u30a4\u30e0\u30a2\u30a6\u30c8\u4ed8\u304d\u306e\u5b9f\u884c
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "起動" to "実行" as it would be a better translation for "run" in this context.

@@ -1,4 +1,3 @@
<p>
Jenkins の Executor.html#isLikelyStuck() で使用されている方法を用い、ビルドが過去の実績から推定される最大のビルド時間を超えている場合にタイムアウトします。
<br/>
過去の実行に比べて極端に長い時間ビルドが実行されている場合にタイムアウトと判定します。
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated from help.html: Abort the build when the job has taken many times longer than previous runs.

@@ -1,6 +1,6 @@
# The MIT License
#
# Copyright (c) 2015, Fernando Migu�lez <[email protected]>
# Copyright (c) 2004-2016, Sun Microsystems, Inc., Seiji Sogabe
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some how it is diaplayed as renamed from LikelyStuckTimeOutStrategy/config_es.properties even though it is actually commited as renamed from LikelyStuckTimeOutStrategy/config_ja.properties.
Anyway, LikelyStuckTimeOutStrategy/config_*.properties is unnecessary as ditto.

@ikedam
Copy link
Member Author

ikedam commented Jan 28, 2017

@ssogabe I updated #62.
Would you review this change?

@ikedam ikedam changed the title Japanes translation (updates #62) Improve Japanese translations Oct 5, 2017
@ikedam ikedam merged commit 5dd0508 into jenkinsci:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants