Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to badge-plugin 2.x #995

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Upgrade to badge-plugin 2.x #995

merged 3 commits into from
Sep 25, 2024

Conversation

strangelookingnerd
Copy link
Contributor

Restores compatibility with latest badge-plugin version. See discussion in jenkinsci/badge-plugin#190

This also updates the baseline to 2.440.x

Testing done

Ran existing tests without issue. I did only try a limited set of manual UI tests, a second pair of eyes would be appreciated.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner September 20, 2024 08:14
* new baseline 2.440.x
@strangelookingnerd
Copy link
Contributor Author

strangelookingnerd commented Sep 20, 2024

The fixes to the UI tests are required for the baseline upgrade and the changes that came with it.

@jenkinsci/build-monitor-plugin-developers I'd be happy for a timely review and release 👍🏼

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I am just keeping this plugin on life support. I don't use it and I have no time to do manual testing.

@basil basil merged commit 14b56ae into jenkinsci:master Sep 25, 2024
16 checks passed
@basil basil added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 25, 2024
@strangelookingnerd strangelookingnerd deleted the upgrade_badge-plugin branch September 25, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants