[JENKINS-72474] Additional informations on BFA scans #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
reviewed
Dec 15, 2023
| /** | ||
| * To call when the scan is finished. | ||
| */ | ||
| public void finished() { |
There was a problem hiding this comment.
I would maybe make this package-private if possible or if not, add @Restricted(NoExternalUse.class).
|
|
||
| private Long endTime; | ||
|
|
||
| private Exception exception; |
There was a problem hiding this comment.
FWIW, exceptions are not always lightweight from a serialization standpoint. Maybe safer to just store Exception.toString as a String exceptionMessage or even boolean scanFailed and let people look at the log for details.
rsandell
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-72474
Additional informations on
ScanLogActionfor plugins to know the current scan status:Testing done
Submitter checklist