Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduleBuild() uses the deprecated LegacyCodeCause #7

Merged
merged 1 commit into from
Sep 11, 2015

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 24, 2015

Led to junk in indexing.xml like this:

<?xml version='1.0' encoding='UTF-8'?>
<jenkins.branch.MultiBranchProject_-BranchIndexing plugin="[email protected]">
  <actions>
    <hudson.model.CauseAction>
      <causes>
        <hudson.model.Cause_-LegacyCodeCause>
          <stackTrace>
            <trace>hudson.model.Cause$LegacyCodeCause.&lt;init&gt;(Cause.java:130)</trace>
            <trace>jenkins.branch.MultiBranchProject.scheduleBuild(MultiBranchProject.java:2002)</trace>
            …
          </stackTrace>
        </hudson.model.Cause_-LegacyCodeCause>
      </causes>
    </hudson.model.CauseAction>
  </actions>
  …
</jenkins.branch.MultiBranchProject_-BranchIndexing>

@reviewbybees esp. @stephenc

@ghost
Copy link

ghost commented Aug 24, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev
Copy link
Member

🐝
Not important: Would be 🐝 😄 if Javadocs of deprecated methods refer the right ones

@tfennelly
Copy link
Member

🐝

@jglick
Copy link
Member Author

jglick commented Aug 25, 2015

I guess you can figure out that the method has non-deprecated overloads. :-)

@jglick
Copy link
Member Author

jglick commented Aug 25, 2015

@reviewbybees done

@ghost
Copy link

ghost commented Aug 25, 2015

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

jglick added a commit that referenced this pull request Sep 11, 2015
scheduleBuild() uses the deprecated LegacyCodeCause
@jglick jglick merged commit ff366f0 into jenkinsci:master Sep 11, 2015
@jglick jglick deleted the LegacyCodeCause branch September 11, 2015 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants