[JENKINS-74783] Fix job name line break behavior in Firefox #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes https://issues.jenkins.io/browse/JENKINS-74783 I think |
daniel-beck
changed the title
|
@mawinter69 Thanks, updated PR title and linked from there to here. |
rsandell
approved these changes
Oct 29, 2024
janfaracik
approved these changes
Oct 29, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#476 evidently was not tested in Firefox, which has awkward line break behavior with an
inline-flex. https://ci.jenkins.io/job/Core/job/jenkins/view/change-requests/ looks like this:This changes the column to be more consistent with https://github.com/jenkinsci/jenkins/blob/e1f99468fd81d6aa52dc434fefc6e0420e1cb449/core/src/main/resources/hudson/views/JobColumn/column.jelly#L29.
Tested only with browser dev tools in Firefox so far.
Lazy branch, please delete on merge if GH doesn't do it.