add configuration-as-code plugin to Bill of Material #78

jetersen · 2019-08-27T19:02:31Z

cc @jglick @oleg-nenashev hopefully I did this right 😅

jglick

Triggers a test failure in git. Probably something for @MarkEWaite to fix (incompatibility with newer versions of configuration-as-code?) but TBD. If the failure is triaged and fixed in a separate PR, then we can go ahead with this after excluding that test suite until the other PR is merged and released.

bom/pom.xml

jglick · 2019-08-27T20:30:01Z

sample-plugin/src/test/java/io/jenkins/tools/bom/sample/ConfigurationAsCodeTest.java

+
+    @Test
+    public void smokes() {
+        assertThat(Jenkins.get().getSystemMessage(), is("Hello World"));


A bit more interesting to configure some object defined in this plugin, but good enough for now I guess.

There is nothing really interesting to configure in JCasC 😆
Though we could use it to smoke test all other plugins 😆

I mean, currently this plugin does not define any global settings, but it could. Whether that would make test coverage any more meaningful for BOM updates is another question.

91d7c3e hmm
@MarkEWaite 😅

Just wanna state BOM and PCT is pretty awesome! Kudos 😍

Should I remove the test?

It is fine.

MarkEWaite · 2019-08-27T21:09:35Z

That test failure is fixed in git client plugin 2.8.2. The JCasC plugin updated its test definition and the git client plugin was updated to use the most recent JCasC plugin tests.

Co-Authored-By: Jesse Glick <[email protected]>

jglick · 2019-08-28T01:00:51Z

Well that fixed the git failure; now we have other failures related to configuration-as-code:

ssh-credentials was apparently testing against a version predating a security fix.
ssh-slaves fails for some reason not immediately obvious to me.

jetersen · 2019-08-28T01:10:39Z

Same issue. They both need updating of JCasC just as Git did.

jetersen · 2019-08-28T01:21:37Z

@MRamonLeon are you up for fixing them? 😅

MRamonLeon · 2019-08-28T07:44:21Z

Sorry @Casz, I don't have enough bandwidth right now, maybe next week.
For ssh-slaves, looks like JCasC is not executing after the restart, there isn't any log of JCasC.

For ssh-credentials, maybe a security issue has been solved and the log doesn't contain the plain password anymore and the test needs to be fixed:
The log should have 'passphrase = passphrase-of-userid2'

0.690 [id=693] FINE i.j.p.c.i.c.DataBoundConfigurator#tryConstructor: Setting class com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey. passphrase = ****

Please take into account that the RoundTripAbstractTest test I did is just a proxy, a utility to develop JCasC complete tests quickly, so it's going to be in the middle of every failure, but don't shoot the messenger 😅

jetersen · 2019-08-28T07:48:20Z

@MRamonLeon I'll see if I have bandwidth for it 😅

jetersen · 2019-09-08T20:20:18Z

Looking into ssh-credentials 😓

timja · 2019-09-08T20:21:02Z

Looking into ssh-credentials 😓

hah, I just created a branch on that repo, it'll require this to be merged:
jenkinsci/configuration-as-code-plugin#1049

jetersen · 2019-09-08T20:21:50Z

Okay I'll look into the other one @timja so looking into ssh-slaves 😓

jetersen · 2019-09-08T20:24:44Z

I see someone else did my work: jenkinsci/ssh-agents-plugin#147 thanks @fcojfernandez

jetersen · 2019-09-10T15:54:54Z

@jglick would you prefer dependabot updating the deps or are you okay with me updating the deps in this PR?

jglick · 2019-09-10T16:33:17Z

If you have some dependencies related to this change that you see could be updated, by all means update them.

jetersen · 2019-09-13T00:13:08Z

@MarkEWaite any idea why these fail consistently:

pct-git-client / test_getAllLogEntries – org.jenkinsci.plugins.gitclient.JGitAPIImplTest
pct-git-client / test_getAllLogEntries – org.jenkinsci.plugins.gitclient.JGitApacheAPIImplTest

https://ci.jenkins.io/blue/organizations/jenkins/Tools%2Fbom/detail/PR-78/11/tests ?

MarkEWaite · 2019-09-13T05:12:46Z

@Casz the getAllLogEntries test compares the output of git log --all origin/master between command line git and JGit. The JGit 4.5 and JGit 5.4 output differs from the command line git output when two commits have a timestamp of the same second.

I've disabled the assertion in that test on the development branches (master and stable-2.8) of the git client plugin because the test is checking a deprecated method and is not very useful. However, the released git client plugin 2.8.5 includes that test and now fails due to the recent commits on the master branch.

If you need a git client plugin release that includes that change, you can either use git client plugin 3.0.0-beta11 or an incremental build from the master branch.

bom/pom.xml

jetersen · 2019-09-16T17:06:09Z

🙏 for green

jetersen · 2019-09-16T17:38:18Z

@jglick not sure the CI is so red 😕❓

stale

jglick · 2019-09-16T17:44:51Z

the CI is so red

Sigh, yes, seems like Remoting problems on ci.jenkins.io again.

timja · 2019-09-17T17:24:52Z

the CI is so red

Sigh, yes, seems like Remoting problems on ci.jenkins.io again.

I can't even load this CI job =/, it's been loading for +20 mins

timja · 2019-09-18T07:55:08Z

🙏

timja · 2019-09-18T08:41:23Z

Whoop green, cc @jglick

jetersen · 2019-09-18T08:47:43Z

This would be great to get merged!

oleg-nenashev

LGTM, thanks for all downstream changes to make it happen!

add configuration-as-code plugin to Bill of Material

19a2a44

jglick previously requested changes Aug 27, 2019

View reviewed changes

This was referenced Aug 27, 2019

[JENKINS-59081] Include test for jcasc compatibility jenkinsci/antisamy-markup-formatter-plugin#13

Merged

Use latest parent pom, test with JCasC and BOM jenkinsci/git-plugin#746

Merged

copy-pasta'd too hard

4ed68ce

Co-Authored-By: Jesse Glick <[email protected]>

timja mentioned this pull request Sep 8, 2019

Fix space in logs jenkinsci/configuration-as-code-plugin#1049

Merged

6 tasks

timja mentioned this pull request Sep 8, 2019

Bump jcasc version to post security fixes jenkinsci/ssh-credentials-plugin#44

Merged

bump jcasc to v1.30

180d23d

This was referenced Sep 9, 2019

fix space in expected log jenkinsci/ssh-agents-plugin#149

Merged

Tests: Fix space in expected log after the bugfix in JCasC 1.30 jenkinsci/mailer-plugin#64

Merged

jglick added the enhancement New feature or request label Sep 11, 2019

jetersen added 2 commits September 12, 2019 22:52

Merge branch 'master' into feat/addJCasC

e74cf6c

add intellij items to gitignore

6e805fe

test out git client 3.0.0-beta11

13bae09

timja reviewed Sep 13, 2019

View reviewed changes

bom/pom.xml Outdated Show resolved Hide resolved

Merge branch 'master' into feat/addJCasC

415436f

jglick self-requested a review September 16, 2019 17:39

jetersen closed this Sep 18, 2019

jetersen reopened this Sep 18, 2019

timja approved these changes Sep 18, 2019

View reviewed changes

oleg-nenashev approved these changes Sep 18, 2019

View reviewed changes

jglick approved these changes Sep 18, 2019

View reviewed changes

jglick merged commit b10cc76 into jenkinsci:master Sep 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add configuration-as-code plugin to Bill of Material #78

add configuration-as-code plugin to Bill of Material #78

jetersen commented Aug 27, 2019

jglick left a comment

jglick Aug 27, 2019

jetersen Aug 27, 2019 •

edited

Loading

jglick Aug 27, 2019

jetersen Aug 28, 2019

jetersen Aug 28, 2019

jetersen Sep 8, 2019

jglick Sep 9, 2019

MarkEWaite commented Aug 27, 2019

jglick commented Aug 28, 2019

jetersen commented Aug 28, 2019

jetersen commented Aug 28, 2019

MRamonLeon commented Aug 28, 2019

jetersen commented Aug 28, 2019

jetersen commented Sep 8, 2019

timja commented Sep 8, 2019

jetersen commented Sep 8, 2019

jetersen commented Sep 8, 2019

jetersen commented Sep 10, 2019

jglick commented Sep 10, 2019

jetersen commented Sep 13, 2019 •

edited

Loading

MarkEWaite commented Sep 13, 2019 •

edited

Loading

jetersen commented Sep 16, 2019

jetersen commented Sep 16, 2019 •

edited

Loading

jglick commented Sep 16, 2019

timja commented Sep 17, 2019

timja commented Sep 18, 2019

timja commented Sep 18, 2019

jetersen commented Sep 18, 2019

oleg-nenashev left a comment

add configuration-as-code plugin to Bill of Material #78

add configuration-as-code plugin to Bill of Material #78

Conversation

jetersen commented Aug 27, 2019

jglick left a comment

Choose a reason for hiding this comment

jglick Aug 27, 2019

Choose a reason for hiding this comment

jetersen Aug 27, 2019 • edited Loading

Choose a reason for hiding this comment

jglick Aug 27, 2019

Choose a reason for hiding this comment

jetersen Aug 28, 2019

Choose a reason for hiding this comment

jetersen Aug 28, 2019

Choose a reason for hiding this comment

jetersen Sep 8, 2019

Choose a reason for hiding this comment

jglick Sep 9, 2019

Choose a reason for hiding this comment

MarkEWaite commented Aug 27, 2019

jglick commented Aug 28, 2019

jetersen commented Aug 28, 2019

jetersen commented Aug 28, 2019

MRamonLeon commented Aug 28, 2019

jetersen commented Aug 28, 2019

jetersen commented Sep 8, 2019

timja commented Sep 8, 2019

jetersen commented Sep 8, 2019

jetersen commented Sep 8, 2019

jetersen commented Sep 10, 2019

jglick commented Sep 10, 2019

jetersen commented Sep 13, 2019 • edited Loading

MarkEWaite commented Sep 13, 2019 • edited Loading

jetersen commented Sep 16, 2019

jetersen commented Sep 16, 2019 • edited Loading

jglick commented Sep 16, 2019

timja commented Sep 17, 2019

timja commented Sep 18, 2019

timja commented Sep 18, 2019

jetersen commented Sep 18, 2019

oleg-nenashev left a comment

Choose a reason for hiding this comment

jetersen Aug 27, 2019 •

edited

Loading

jetersen commented Sep 13, 2019 •

edited

Loading

MarkEWaite commented Sep 13, 2019 •

edited

Loading

jetersen commented Sep 16, 2019 •

edited

Loading