Skip to content

Add Email Extension to the managed set #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jun 12, 2021

I don't feel particularly strongly about including this in the BOM, but if tests pass and it improves compatibility testing for a moderately popular plugin, why not?

@basil
Copy link
Member Author

basil commented Jun 13, 2021

Ugh, UI testing is the worst. Apparently this makes hudson.tasks.MailerTest#globalConfig start failing because it is picking the wrong form elements (the ones from Email Extension rather than its own).

@jglick jglick added the enhancement New feature or request label Dec 3, 2021
@jglick
Copy link
Member

jglick commented Dec 3, 2021

Apparently this makes hudson.tasks.MailerTest#globalConfig start failing because it is picking the wrong form element

I wonder if jenkinsci/jenkins#5926 will make this easier?

@basil basil marked this pull request as ready for review February 3, 2022 22:18
@basil
Copy link
Member Author

basil commented Feb 3, 2022

Somehow the passage of time has fixed this, for reasons unknown to me.

@jglick jglick merged commit aac3b33 into jenkinsci:master Feb 3, 2022
@basil basil deleted the email-ext branch February 4, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants