Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ssh-credentials for 2.452.x #4036

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

darinpope
Copy link
Contributor

When adding some other plugins, I kept hitting the following issue:

Caused by: java.io.IOException: Failed to load: SSH Credentials Plugin (ssh-credentials 349.vb_8b_6b_9709f5b_)
- Update required: Trilead API Plugin (trilead-api 2.142.v748523a_76693) to be updated to 2.147.vb_73cc728a_32e or higher

for the following plugins only for the 2.452.x line:

  • build-failure-analyzer
  • docker-workflow
  • git-parameter
  • git
  • git-server
  • workflow-basic-steps
  • pipeline-model-definition
  • jenkins-design-language

This was probably introduced with #4028.

Pinning to the previous version just for 2.452.x to see if it resolves.

Testing done

2.452.x LINE tests for a few of the plugins that were failing before the pin, i.e.:

LINE=2.452.x PLUGINS=build-failure-analyzer bash local-test.sh

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

When adding some other plugins, I kept hitting the following issue:

```
Caused by: java.io.IOException: Failed to load: SSH Credentials Plugin (ssh-credentials 349.vb_8b_6b_9709f5b_)
- Update required: Trilead API Plugin (trilead-api 2.142.v748523a_76693) to be updated to 2.147.vb_73cc728a_32e or higher
```
for the following plugins only for the `2.452.x` line:

* build-failure-analyzer
* docker-workflow
* git-parameter
* git
* git-server
* workflow-basic-steps
* pipeline-model-definition
* jenkins-design-language

This was probably introduced with jenkinsci#4028.

Pinning to the previous version just for 2.452.x to see if it resolves.
@darinpope darinpope added the full-test Test all LTS lines in this PR and do not halt upon first error. label Nov 28, 2024
@darinpope
Copy link
Contributor Author

Merging even with failures...all failures were 403 proxy

@darinpope darinpope marked this pull request as ready for review November 28, 2024 02:32
@darinpope darinpope requested a review from a team as a code owner November 28, 2024 02:32
@darinpope darinpope merged commit 4ab84db into jenkinsci:master Nov 28, 2024
902 of 916 checks passed
@darinpope darinpope deleted the fix-ssh-credentials branch November 28, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant