Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Groovy Postbuild plugin to managed set #3751

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

MarkEWaite
Copy link
Contributor

Add Groovy Postbuild plugin to managed set

Fix #3635

Plugin has over 19000 installations and is used regularly when testing new Jenkins releases. Was affected by the badge 2.0 compatibility break and has been adapted to that change in the release that is included in bom-weekly/pom.xml.

Testing done

Confirmed that tests pass for this plugin with:

PLUGINS=groovy-postbuild bash local-test.sh

Also confirmed that the tests fail with the older version of the plugin.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Fix jenkinsci#3635

Plugin has over 19000 installations and is used regularly when testing
new Jenkins releases.  Was affected by the badge 2.0 compatibility break
and has been adapted to that change in the release that is included
in bom-weekly/pom.xml.

Confirmed that tests pass for this plugin with:

PLUGINS=groovy-postbuild bash local-test.sh

Also confirmed that the tests fail with the older version of the plugin.
@MarkEWaite MarkEWaite requested a review from a team as a code owner October 13, 2024 12:21
@MarkEWaite MarkEWaite added the full-test Test all LTS lines in this PR and do not halt upon first error. label Oct 13, 2024
@darinpope darinpope self-assigned this Oct 13, 2024
Copy link
Contributor

@darinpope darinpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran all 4 LINEs local-test and all succeeded.

@MarkEWaite MarkEWaite enabled auto-merge (squash) October 13, 2024 12:59
@MarkEWaite MarkEWaite disabled auto-merge October 13, 2024 13:00
@MarkEWaite MarkEWaite merged commit f48bc85 into jenkinsci:master Oct 14, 2024
789 of 792 checks passed
@MarkEWaite MarkEWaite deleted the add-groovy-postbuild branch October 14, 2024 04:31
@MarkEWaite
Copy link
Contributor Author

Merged even with the http_request test failure, because that failure is a transient due to GitHub API failure.

@MarkEWaite MarkEWaite added the enhancement New feature or request label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Groovy Postbuild to the managed set
2 participants