Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test against RC build 2.462.3 #3597

Conversation

krisstern
Copy link
Member

@krisstern krisstern commented Sep 18, 2024

Test against RC build of 2.462.3

Only for testing. Please do not merge.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@krisstern krisstern requested a review from a team as a code owner September 18, 2024 05:35
@krisstern krisstern mentioned this pull request Sep 18, 2024
45 tasks
@krisstern
Copy link
Member Author

🟢 All tests passed

@krisstern krisstern closed this Sep 18, 2024
@MarkEWaite MarkEWaite added the full-test Test all LTS lines in this PR and do not halt upon first error. label Sep 18, 2024
@MarkEWaite
Copy link
Contributor

@krisstern by default, pull requests to this repository run a very few operations. I've added the full-test label and reopened the pull request so that the full set of tests will be run with the pre-release.

@MarkEWaite MarkEWaite reopened this Sep 18, 2024
@krisstern
Copy link
Member Author

Hey @MarkEWaite, thanks for reopening the PR and adding the full-test label for me. I do remember it but I don't think I have permissions to add a label to it, or I do not know the GitHub command for it. Would it be possible for me to have write access to this repo moving forward, or if there is a command for it for you to teach me how to do it?

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Sep 18, 2024

Hey @MarkEWaite, thanks for reopening the PR and adding the full-test label for me. I do remember it but I don't think I have permissions to add a label to it, or I do not know the GitHub command for it. Would it be possible for me to have write access to this repo moving forward, or if there is a command for it for you to teach me how to do it?

We'd love to have you as a maintainer of the plugin bill of materials if you have capacity. If you don't feel like you have capacity to be a plugin BOM maintainer, then you can use the technique described in the README:

To minimize cloud resources, PCT is not run at all by default on pull requests, only some basic sanity checks. Add the label full-test to run PCT in a PR. If you lack triage permission and so cannot add this label, then you may instead

echo 'TODO delete me' > full-test
git add full-test
git commit -m 'Run full tests'

while keeping the PR in draft until tests pass and this file can be deleted.

@krisstern
Copy link
Member Author

Hi @MarkEWaite,

Sure, I would love to be a maintainer of bom.
Does the checks look alright with you? I see we have 1 check errored and 2 checks failed.

@MarkEWaite
Copy link
Contributor

Sure, I would love to be a maintainer of bom.

Does the checks look alright with you? I see we have 1 check errored and 2 checks failed.

The failure was infrastructure related. It reported:

06:38:50  [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:install-node-and-npm (install node and npm) on project data-tables-api: Could not download Node.js: Could not download https://nodejs.org/dist/v20.13.1/node-v20.13.1-linux-x64.tar.gz: Premature end of Content-Length delimited message body (expected: 46,721,240; received: 2,711,552) -> [Help 1]
06:38:50  org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:install-node-and-npm (install node and npm) on project data-tables-api: Could not download Node.js: Could not download https://nodejs.org/dist/v20.13.1/node-v20.13.1-linux-x64.tar.gz

The other failing checks are a result of that infrastructure issue.

We could consider adding NodeJS download caching like we have for Maven artifacts, but the failure is rare and there are other infra improvements that are more valuable for now.

@MarkEWaite MarkEWaite closed this Sep 18, 2024
@krisstern krisstern deleted the test/test-against-rc-build-2.462.3 branch September 18, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants