Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73282] Run PCT with a Jetty 12 EE 8 test harness when core is Jetty 12 EE 8 #3190

Merged
merged 1 commit into from
Aug 14, 2024
Merged

[JENKINS-73282] Run PCT with a Jetty 12 EE 8 test harness when core is Jetty 12 EE 8 #3190

merged 1 commit into from
Aug 14, 2024

Conversation

basil
Copy link
Member

@basil basil commented May 9, 2024

No description provided.

@basil
Copy link
Member Author

basil commented May 9, 2024

Looks like about 7 plugins are linking against Jetty 10.x APIs and will need to be adapted to Jetty 12.x APIs. That is a manageable number.

@basil basil mentioned this pull request May 9, 2024
Closed
@basil basil closed this May 9, 2024
@basil basil reopened this May 22, 2024
@basil basil changed the title Test Jetty 12.0.9 (EE 8) Test Jetty 12.0.9 (EE 8) in full mode (i.e., with EE 8 test harness) May 22, 2024
@basil basil force-pushed the prototype branch 5 times, most recently from 0130ac0 to 7c7616e Compare May 22, 2024 15:51
@basil basil force-pushed the prototype branch 4 times, most recently from 887be4e to 6760a66 Compare June 3, 2024 21:10
@basil basil changed the title Test Jetty 12.0.9 (EE 8) in full mode (i.e., with EE 8 test harness) Test Jetty 12.0.10 (EE 8) in full mode (i.e., with EE 8 test harness) Jun 3, 2024
@basil basil force-pushed the prototype branch 2 times, most recently from 4e2c911 to 5a60a14 Compare June 4, 2024 01:35
@basil basil force-pushed the prototype branch 4 times, most recently from aca26e7 to f9e962a Compare June 18, 2024 23:09
@basil basil changed the title Test Jetty 12.0.10 (EE 8) in full mode (i.e., with EE 8 test harness) [JENKINS-73282] Run PCT with a Jetty 12 EE 8 test harness when core is Jetty 12 EE 8 Jun 18, 2024
@basil basil force-pushed the prototype branch 6 times, most recently from 89821f5 to 0e5592a Compare June 24, 2024 15:19
@basil basil force-pushed the prototype branch 5 times, most recently from 5ea542d to 06d1ddf Compare August 12, 2024 17:30
@basil basil added full-test Test all LTS lines in this PR and do not halt upon first error. weekly-test and removed weekly-test full-test Test all LTS lines in this PR and do not halt upon first error. labels Aug 12, 2024
@basil basil force-pushed the prototype branch 3 times, most recently from 65d86c4 to 4129d3d Compare August 13, 2024 20:03
@basil basil added full-test Test all LTS lines in this PR and do not halt upon first error. and removed weekly-test work-in-progress labels Aug 14, 2024
@basil basil marked this pull request as ready for review August 14, 2024 16:24
@basil basil requested a review from a team as a code owner August 14, 2024 16:24
MarkEWaite
MarkEWaite approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great. Combines the changes from:

@basil
Copy link
Member Author

basil commented Aug 14, 2024 •
edited
Loading

These failures all seem to be caused by Artifact Caching Proxy (ACP) not being able to fetch a dependency:

  • git-server-plugin-2.462.x
  • pipeline-graph-analysis-plugin-weekly
  • ws-cleanup-plugin-2.440.x

I cannot reproduce these failures locally, and I am not changing these plugins (so I don't think this PR is the cause). Additionally, I ran a full test on Monday before the core release and got a similar number of flakes (in a different set of plugins), which indicates to me that re-running the test wouldn't necessarily help. I am still not sure how BOM releases can be done with this level of infrastructure flakiness. Maybe today is just an unlucky day.

@MarkEWaite
Copy link
Contributor

These failures all seem to be caused by Artifact Caching Proxy (ACP) not being able to fetch a dependency:

  • git-server-plugin-2.462.x
  • pipeline-graph-analysis-plugin-weekly
  • ws-cleanup-plugin-2.440.x

I cannot reproduce these failures locally, and I am not changing these plugins (so I don't think this PR is the cause). Additionally, I ran a full test on Monday before the core release and got a similar number of flakes (in a different set of plugins), which indicates to me that re-running the test wouldn't necessarily help. I am still not sure how BOM releases can be done with this level of infrastructure flakiness. Maybe today is just an unlucky day.

I think we should merge this pull request even though the artifact caching proxy flakiness is causing some random test failures. Last week's BOM release was successful on the first try. We can try a BOM release today or tomorrow and if there is an infrastructure failure we can ask @dduportal to investigate when he is in the office on Friday.

@basil basil mentioned this pull request Aug 14, 2024
Closed
@basil
Copy link
Member Author

basil commented Aug 14, 2024

Agreed, and I filed jenkins-infra/helpdesk#4241 with the logs I captured from this run.

@basil basil merged commit f18eacb into jenkinsci:master Aug 14, 2024
719 of 724 checks passed
This was referenced Aug 14, 2024
Closed
Closed
Closed
@basil basil deleted the prototype branch August 14, 2024 18:46
@basil basil added the enhancement New feature or request label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request full-test Test all LTS lines in this PR and do not halt upon first error.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basil @MarkEWaite