-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump git-plugin.version from 4.14.1 to 4.14.2 in /bom-weekly #1623
Bump git-plugin.version from 4.14.1 to 4.14.2 in /bom-weekly #1623
Conversation
Bumps `git-plugin.version` from 4.14.1 to 4.14.2. Updates `git` from 4.14.1 to 4.14.2 - [Release notes](https://github.com/jenkinsci/git-plugin/releases) - [Changelog](https://github.com/jenkinsci/git-plugin/blob/master/CHANGELOG.adoc) - [Commits](jenkinsci/git-plugin@git-4.14.1...git-4.14.2) Updates `git` from 4.14.1 to 4.14.2 - [Release notes](https://github.com/jenkinsci/git-plugin/releases) - [Changelog](https://github.com/jenkinsci/git-plugin/blob/master/CHANGELOG.adoc) - [Commits](jenkinsci/git-plugin@git-4.14.1...git-4.14.2) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:git dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jenkins-ci.plugins:git:tests dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot merge
@dependabot squash and merge |
Can be reproduced in $ mvn -Denforcer.skip=true -Dhpi-plugin.version=3.37 -Djenkins.version=2.381 -Djth.jenkins-war.path=/home/basil/src/jenkinsci/bom/target/local-test/megawar.war -DoverrideWar=/home/basil/src/jenkinsci/bom/target/local-test/megawar.war -DoverrideWarAdditions=true -Dtest=InjectedTest -DupperBoundsExcludes=javax.servlet:servlet-api -DuseUpperBounds=true clean verify after running in $ PLUGINS=git TEST=InjectedTest bash local-test.sh to build the megawar. Bisection shows the trouble started occurring at jenkinsci/git-plugin#1369 which updated Verified that the problem can be successfully worked around in diff --git a/pom.xml b/pom.xml
index 3753e57c..e187d4f4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -79,6 +79,11 @@
<type>pom</type>
<scope>import</scope>
</dependency>
+ <dependency>
+ <groupId>org.jenkins-ci.plugins</groupId>
+ <artifactId>conditional-buildstep</artifactId>
+ <version>1.4.2</version>
+ </dependency>
</dependencies>
</dependencyManagement> But a better solution would be to upgrade OK, so who is going to implement this? I am not just talking. If you want me to do it Mark feel free to create an issue and assign it to me, and it will be taken care of with the speed you know me for. If you want to do this yourself that is fine too. If you think we should ask someone else, I would be happy to guide them through the changes. |
Thanks so much for the detailed analysis. Much appreciated! I'll need to study your technique so that I can use it in the future. I'd like to handle it by releasing a new version of the git plugin without placing a dependency on the release of another plugin. I should be able to release the new version within the next 24 hours. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
I "fat fingered" the close of this pull request, but ultimately it would need to be closed anyway, since a new release of git plugin will be needed to solve the problem. |
Bumps
git-plugin.version
from 4.14.1 to 4.14.2.Updates
git
from 4.14.1 to 4.14.2Release notes
Sourced from git's releases.
Commits
f166cef
[maven-release-plugin] prepare release git-4.14.29a4ddc2
Do not assert changeset paths are unique699eef5
Better message in assertionc8dff1b
Make objectID more readable in assertion failurec41d570
Merge pull request #1371 from jenkinsci/dependabot/maven/master/nl.jqno.equal...0acb753
Bump equalsverifier from 3.11.1 to 3.12.1dd3658d
Improve assertion failure message in browser testce8b936
Merge pull request #1369 from jenkinsci/dependabot/maven/org.jenkins-ci.plugi...7a5afa3
Require at least promoted builds 3.1157a7af3
Bump parameterized-trigger from 2.39 to 2.43.1Updates
git
from 4.14.1 to 4.14.2Release notes
Sourced from git's releases.
Commits
f166cef
[maven-release-plugin] prepare release git-4.14.29a4ddc2
Do not assert changeset paths are unique699eef5
Better message in assertionc8dff1b
Make objectID more readable in assertion failurec41d570
Merge pull request #1371 from jenkinsci/dependabot/maven/master/nl.jqno.equal...0acb753
Bump equalsverifier from 3.11.1 to 3.12.1dd3658d
Improve assertion failure message in browser testce8b936
Merge pull request #1369 from jenkinsci/dependabot/maven/org.jenkins-ci.plugi...7a5afa3
Require at least promoted builds 3.1157a7af3
Bump parameterized-trigger from 2.39 to 2.43.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @MarkEWaite.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)