Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test project configure page #1133

Closed
wants to merge 6 commits into from
Closed

Conversation

timja
Copy link
Member

@timja timja commented May 16, 2022

@timja timja changed the title Re test project configure page Test project configure page May 16, 2022
@janfaracik
Copy link

Don't suppose you know if this is one of those hard to debug errors due to using some new JS syntax? Nothing is particularly standing out in the JS

@timja
Copy link
Member Author

timja commented May 16, 2022

Don't suppose you know if this is one of those hard to debug errors due to using some new JS syntax? Nothing is particularly standing out in the JS

I expect some expected element isn't being found which is breaking it, not sure why, haven't had a chance to look

@basil
Copy link
Member

basil commented May 17, 2022

The ReadManifestStepTest failures were caused by a minor incompatibility introduced in jenkinsci/remoting#532 combined with the lack of timely merge and release of jenkinsci/pipeline-utility-steps-plugin#143. I have worked around the problem in #1145 by excluding the test class.

@janfaracik
Copy link

Finally had the time to have a dabble in this and it seems that the fix should be to update the test harness, htmlunit 2.59.0 and below give the Cannot call method "addEventListener" of null error, versions above that don't. I'll open some PRs to get the repos up to date.

@timja
Copy link
Member Author

timja commented Jun 26, 2022

Passing now, only matrix-auth unreleased, we can exclude the tests if it doesn't get released in time, it's a tests only issue

@timja timja closed this Jul 7, 2022
@timja timja deleted the re-test-project-configure-page branch July 7, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants