add updatecli for plugins #1063

jetersen · 2022-04-23T11:18:38Z

fixes #1019

This will find the latest Jenkins version matching the x.xx.x and check each plugin in the specified pom.xml

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue

jetersen · 2022-04-23T11:20:07Z

Okay not sure why it reports: bash: ./updatecli/updatecli.d/update-plugins.sh: No such file or directory

I had the same issue locally but I can't figure out why it is not able to see the shell scripts 🤔

jetersen · 2022-04-23T11:55:37Z

Tested locally with changed values.yaml

diff --git a/updatecli/values.yaml b/updatecli/values.yaml
index ac89ff5..12022d4 100644
--- a/updatecli/values.yaml
+++ b/updatecli/values.yaml
@@ -3,6 +3,6 @@ github:
   email: "41898282+github-actions[bot]@users.noreply.github.com"
   username: "github-actions"
   token: "UPDATECLI_GITHUB_TOKEN"
-  owner: "jenkinsci"
-  repository: "bom"
-  branch: "master"
\ No newline at end of file
+  owner: "jetersen"
+  repository: "jenkins-bom"
+  branch: "fix/bomPlugins"

jetersen · 2022-04-23T12:20:06Z

locally bash/powershell scripts works as intended

however having updatecli run the scripts it messes with the standard out of java cli inside powershell

--debug shows that it cannot find my java cli 😕

jetersen · 2022-04-23T12:52:49Z

https://github.com/jenkinsci/bom/runs/6140231752?check_suite_focus=true#step:5:191 Yup working 👏

updatecli/updatecli.d/update-plugins.ps1

updatecli/values.yaml

Co-authored-by: Tim Jacomb <[email protected]>

jetersen · 2022-04-23T17:36:22Z

updatecli/updatecli.d/update-plugins.yaml

+      - jenkins2.289.x
+      - jenkins2.303.x
+      - jenkins2.319.x
+      - jenkins2.332.x


we can do one big PR for all boms or multiple PRs for each bom.

Does it matter @timja @basil @jglick ?

You mean when a given plugin gets updates for multiple LTS lines? I think it is fine for those to be separate PRs, since this is not the normal case. A plugin will only be mentioned in a bom-2.*.x/pom.xml when it is overridden there relative to the newer lines, so when Jenkins baselines are updated across more than one LTS bump in a given plugin release, we would only be adding one such entry.

jetersen · 2022-04-23T18:13:10Z

Lets try it, we can always modify it 😄

basil · 2022-04-23T23:35:16Z

But why is this needed if Dependabot is already proposing PRs for these dependencies?

jetersen · 2022-04-24T04:48:24Z

Dependabot was not doing for all of them @basil only once where version number was appended to like credentials 2.6.1 to 2.6.1.1 but not for junit 1.53 to 1.54

basil · 2022-04-24T12:46:11Z

Dependabot was not doing for all of them

Sounds like a bug then, with this PR being a workaround for that bug. But better would be to determine the root cause and fix the original bug.

jetersen · 2022-04-24T12:56:47Z

Well again another problem is that dependabot does not understand the plugin version in relation to the Jenkins version. This fix uses plugin manager to update dependency according to Jenkins version for the certain BOM lines.

basil · 2022-04-24T12:59:49Z

That problem also applies to the plugins in bom-weekly, so if we believe that problem is significant enough to develop a custom solution for non-weekly BOM lines, then by the same logic that problem is significant enough to develop a custom solution for bom-weekly.

jglick

Do not understand how all of it works, but looks good. Thanks!

jglick · 2022-04-25T16:22:25Z

updatecli/updatecli.d/update-plugins.yaml

+      branch: "{{ .github.branch }}"
+
+sources:
+  jenkins2.289.x:


Looks like this file needs to be maintained when adding or removing lines. Would you mind adding a note to https://github.com/jenkinsci/bom/#lts-lines to this effect?

jglick · 2022-04-25T16:25:06Z

updatecli/updatecli.d/update-plugins.yaml

+      - jenkins2.289.x
+      - jenkins2.303.x
+      - jenkins2.319.x
+      - jenkins2.332.x


You mean when a given plugin gets updates for multiple LTS lines? I think it is fine for those to be separate PRs, since this is not the normal case. A plugin will only be mentioned in a bom-2.*.x/pom.xml when it is overridden there relative to the newer lines, so when Jenkins baselines are updated across more than one LTS bump in a given plugin release, we would only be adding one such entry.

jglick · 2022-10-31T13:39:08Z

@jetersen this is pretty broken—it keeps on filing PRs for the same updates we do not want; unlike Dependabot it does not remember that a given update was rejected. Unfortunately my knowledge of all this is very limited and I could not figure out how to cleanly disable just the plugin updates without the core updates.

jetersen · 2022-10-31T14:15:23Z

@jglick I am unsure why these updates incorrect? 🤔

https://github.com/jenkinsci/pipeline-input-step-plugin/blob/d8a957db5be95ddfbf81f41a60b2f034000314b5/pom.xml#L41

Seems fine to me 😕

https://github.com/jenkinsci/bom/blob/master/updatecli/update-plugin.ps1
You/we can introduce a plugin block list here or plugin/version block list 😅

timja · 2022-10-31T14:20:47Z

I think it's this issue, #1507 (comment)

Could just drop the line anyway

jglick · 2022-10-31T14:28:02Z

I think it's this issue

Right.

Could just drop the line anyway

Probably could; it has so many overrides at this point I am not sure there is much point in publishing new BOM releases, especially when we have a new line arriving (I hope) shortly.

introduce a plugin block list here or plugin/version block list

Also an option. (For Dependabot you have this option in the YAML config but you can also just close a PR to reject a given update.) Probably beyond my Powershell skills.

jetersen · 2022-10-31T14:42:42Z

We can have it read a YAML config as well.

We can also decide to turn off plugin updates for certain BOM lines when decided 🤔

add updatecli for plugins

3c44270

jetersen requested a review from jglick April 23, 2022 11:18

jetersen added 3 commits April 23, 2022 14:07

use regex to select version

5a914a7

download plugin manager to updatecli workspace

bff99fa

print output

0efab81

jetersen added 3 commits April 23, 2022 14:32

make sure output is not null

16f2bea

check java

5dc9f0c

test from this branch

5726140

jetersen mentioned this pull request Apr 23, 2022

Keep pinned dependencies in 2.nnn.x/pom.xml up to date #1019

Closed

timja approved these changes Apr 23, 2022

View reviewed changes

updatecli/updatecli.d/update-plugins.ps1 Outdated Show resolved Hide resolved

updatecli/values.yaml Outdated Show resolved Hide resolved

jetersen and others added 2 commits April 23, 2022 19:22

Apply suggestions from code review

c201430

Co-authored-by: Tim Jacomb <[email protected]>

restore pull requests

0793659

jetersen commented Apr 23, 2022

View reviewed changes

timja approved these changes Apr 23, 2022

View reviewed changes

jetersen enabled auto-merge (squash) April 23, 2022 18:13

jetersen merged commit 6a405f9 into jenkinsci:master Apr 23, 2022

jetersen deleted the fix/bomPlugins branch April 24, 2022 04:48

jglick reviewed Apr 25, 2022

View reviewed changes

jglick mentioned this pull request May 10, 2022

Switch jenkins.version recommendation to be 2.xxx.3 rather than 2.xxx.1 (except for latest line) jenkins-infra/jenkins.io#4876

Merged

basil mentioned this pull request May 15, 2022

Weekly updates stopped working #1130

Closed

This was referenced Oct 31, 2022

Bump pipeline-input-step from 451.vf1a_a_4f405289 to 456.vd8a_957db_5b_e9 in /bom-2.319.x #1529

Closed

Bump pipeline-input-step from 451.vf1a_a_4f405289 to 456.vd8a_957db_5b_e9 in /bom-2.319.x #1531

Closed

timja mentioned this pull request Nov 1, 2022

Drop 2.319.x #1543

Merged

jglick mentioned this pull request Nov 3, 2022

Disable updatecli on plugins #1556

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add updatecli for plugins #1063

add updatecli for plugins #1063

jetersen commented Apr 23, 2022

jetersen commented Apr 23, 2022

jetersen commented Apr 23, 2022 •

edited

Loading

jetersen commented Apr 23, 2022 •

edited

Loading

jetersen commented Apr 23, 2022

jetersen Apr 23, 2022 •

edited

Loading

jglick Apr 25, 2022

jetersen commented Apr 23, 2022

basil commented Apr 23, 2022

jetersen commented Apr 24, 2022 •

edited

Loading

basil commented Apr 24, 2022

jetersen commented Apr 24, 2022

basil commented Apr 24, 2022

jglick left a comment

jglick Apr 25, 2022

jglick Apr 25, 2022

jglick commented Oct 31, 2022

jetersen commented Oct 31, 2022 •

edited

Loading

timja commented Oct 31, 2022 •

edited

Loading

jglick commented Oct 31, 2022

jetersen commented Oct 31, 2022

add updatecli for plugins #1063

add updatecli for plugins #1063

Conversation

jetersen commented Apr 23, 2022

jetersen commented Apr 23, 2022

jetersen commented Apr 23, 2022 • edited Loading

jetersen commented Apr 23, 2022 • edited Loading

jetersen commented Apr 23, 2022

jetersen Apr 23, 2022 • edited Loading

Choose a reason for hiding this comment

jglick Apr 25, 2022

Choose a reason for hiding this comment

jetersen commented Apr 23, 2022

basil commented Apr 23, 2022

jetersen commented Apr 24, 2022 • edited Loading

basil commented Apr 24, 2022

jetersen commented Apr 24, 2022

basil commented Apr 24, 2022

jglick left a comment

Choose a reason for hiding this comment

jglick Apr 25, 2022

Choose a reason for hiding this comment

jglick Apr 25, 2022

Choose a reason for hiding this comment

jglick commented Oct 31, 2022

jetersen commented Oct 31, 2022 • edited Loading

timja commented Oct 31, 2022 • edited Loading

jglick commented Oct 31, 2022

jetersen commented Oct 31, 2022

jetersen commented Apr 23, 2022 •

edited

Loading

jetersen commented Apr 23, 2022 •

edited

Loading

jetersen Apr 23, 2022 •

edited

Loading

jetersen commented Apr 24, 2022 •

edited

Loading

jetersen commented Oct 31, 2022 •

edited

Loading

timja commented Oct 31, 2022 •

edited

Loading