Add VMSS support

[timja]

• Switch public IP address to Standard SKU
  • Basic is being retired next year
  • Standard has a change in behaviour which requires an NSG to be on the subnet or network interface
• Change deployment finished to check every 5 seconds instead of 30 seconds, saves ~20 in my testing, from 1min2 to ~40 seconds for provisioning
• Add networking configuration support for basic image configuration templates

Testing done

Triggered a bunch of jobs on an agent template with VMSS configured and added a column to show availability zone:

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[cyclelabs-ryanberger]

@timja Hey, a little confused about Add VMSS Support. I was imaging that this would allow you to interact with an existing VMSS and have the plugin spin up instances as part of the pooled/idle retention policy - this is a common strategy for other CI/CD tools so I got excited when I saw this come in. Can you explain a use case of using the Virtual Machine Scale Sets (recommended) option? I don't see anywhere to configure an actual Scale Set to use within the VM Agent Template. I just want to understand this functionality and its intended use case.

Thanks a ton!

[timja]

Hey,

There should be a dropdown underneath where you can select a name:

Yes this is for existing VMSS (with flexible orchestration enabled).

The plugin just interacts with the VM API as normal but attaches it to a scaleset, the main benefit of it being for availability, VMs will be automatically distributed across availability zones.

[cyclelabs-ryanberger]

@timja That was very weird. I did not see that prompt until after I restarted Jenkins service. I now see it! I will build up a scale set into the resource group we use tomorrow with Terraform and test this. This would be a great use case for us! Thanks a ton!