Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit spotbugs CT_CONSTRUCTOR_THROWS visitor #207

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Omit spotbugs CT_CONSTRUCTOR_THROWS visitor #207

merged 1 commit into from
Dec 21, 2023

Conversation

MarkEWaite
Copy link
Contributor

From jenkinsci/plugin-pom#869 (comment)

Discussion in spotbugs/spotbugs#2695
https://wiki.sei.cmu.edu/confluence/display/java/OBJ11-J.+Be+wary+of+letting+constructors+throw+exceptions
seems to relate to libraries used with SecurityManager which is dead
and certainly does not apply to Jenkins; we do not expect untrusted code
to be running inside the controller JVM, and it does not seem plausible
that finalizer abuse would happen by accident.

@MarkEWaite
Omit spotbugs CT_CONSTRUCTOR_THROWS visitor
32d0ee7 
From jenkinsci/plugin-pom#869 (comment)

> Discussion in spotbugs/spotbugs#2695
> https://wiki.sei.cmu.edu/confluence/display/java/OBJ11-J.+Be+wary+of+letting+constructors+throw+exceptions
> seems to relate to libraries used with SecurityManager which is dead
> and certainly does not apply to Jenkins; we do not expect untrusted code
> to be running inside the controller JVM, and it does not seem plausible
> that finalizer abuse would happen by accident.
@MarkEWaite MarkEWaite requested a review from a team as a code owner December 21, 2023 11:15
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Dec 21, 2023
@github-actions github-actions bot added the dependencies Dependency related change label Dec 21, 2023
@MarkEWaite MarkEWaite merged commit 63a054e into jenkinsci:master Dec 21, 2023
15 checks passed
@MarkEWaite MarkEWaite deleted the omit-constructor-throws-visitor branch December 21, 2023 11:27
@MarkEWaite MarkEWaite removed the dependencies Dependency related change label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite