Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help for irrelevantGroups #26

Merged
merged 1 commit into from
Mar 5, 2016

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Mar 4, 2016

@reviewbybees

@ghost
Copy link

ghost commented Mar 4, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@andresrc
Copy link

andresrc commented Mar 4, 2016

🐝

@@ -3,4 +3,5 @@
This can significantly improve performance in environments with a large number of groups
but a small number of corresponding rules defined by the Authorization Strategy.
The user is required to re-login in order for the changes to take effect.
<br><strong>Note:</strong> this setting may be incompatable with some Authorzation Strategies.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend you to use:

<p>
  <strong>Note:</strong> this setting may be incompatable with some Authorzation Strategies.
</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@recena, you've got a couple typos in your recommended version, corrected below:

<p>
  <strong>Note:</strong> this setting may be incompatible with some Authorization Strategies.
</p>

@recena
Copy link

recena commented Mar 4, 2016

🐝

@fbelzunc fbelzunc changed the title update help for irrelevantGroups Update help for irrelevantGroups Mar 5, 2016
fbelzunc added a commit that referenced this pull request Mar 5, 2016
Update help for irrelevantGroups
@fbelzunc fbelzunc merged commit fcf13ef into jenkinsci:master Mar 5, 2016
@jtnord
Copy link
Member Author

jtnord commented Mar 6, 2016

@reviewbtbees done :-)

@nnordrum
Copy link

nnordrum commented Apr 5, 2017

Any clarity on what Strategies are known to be affected, what might cause a Strategy to be affected, and/or examples of what the effect might look like? This is very doom and gloom with nothing to provide any reassurance that everything isn't going to go to hell in a weird unpredictable way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants