-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update help for irrelevantGroups #26
Conversation
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
🐝 |
@@ -3,4 +3,5 @@ | |||
This can significantly improve performance in environments with a large number of groups | |||
but a small number of corresponding rules defined by the Authorization Strategy. | |||
The user is required to re-login in order for the changes to take effect. | |||
<br><strong>Note:</strong> this setting may be incompatable with some Authorzation Strategies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend you to use:
<p>
<strong>Note:</strong> this setting may be incompatable with some Authorzation Strategies.
</p>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@recena, you've got a couple typos in your recommended version, corrected below:
<p>
<strong>Note:</strong> this setting may be incompatible with some Authorization Strategies.
</p>
🐝 |
Update help for irrelevantGroups
@reviewbtbees done :-) |
Any clarity on what Strategies are known to be affected, what might cause a Strategy to be affected, and/or examples of what the effect might look like? This is very doom and gloom with nothing to provide any reassurance that everything isn't going to go to hell in a weird unpredictable way. |
@reviewbybees