Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple servers without assigned ports #19

Merged

Conversation

nieuwtje
Copy link

@nieuwtje nieuwtje commented Feb 5, 2016

Whenever multiple domain controllers are defined, but they don't have a port assigned, only the last domain controller was given a port -> Added support for multiple servers without assigned ports.

@jtnord
Copy link
Member

jtnord commented Feb 5, 2016

code LGTM - but the history would be a little unclear due to the merge in the ancestry. Can you rebase the change ontop of origin/master?

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@nieuwtje nieuwtje force-pushed the multiple-domain-add-ports-if-missing branch from 6eafcf8 to a1ab420 Compare February 5, 2016 19:16
@nieuwtje nieuwtje force-pushed the multiple-domain-add-ports-if-missing branch from a1ab420 to da41bf6 Compare February 5, 2016 20:23
@jtnord
Copy link
Member

jtnord commented Mar 3, 2016

@fbelzunc FYI.

jtnord added a commit that referenced this pull request Mar 3, 2016
…sing

Added support for multiple servers without assigned ports
@jtnord jtnord merged commit 5372151 into jenkinsci:master Mar 3, 2016
yaroslavafenkin pushed a commit to yaroslavafenkin/active-directory-plugin that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants