Enforce that there are no CSP violations when csp.rule is defined
#1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
force-pushed
the
csp-report-only
branch
4 times, most recently
from
a2fb4ed to
8d5d712
Compare
basil
force-pushed
the
csp-report-only
branch
8 times, most recently
from
42648a9 to
a3a6ccf
Compare
basil
force-pushed
the
csp-report-only
branch
8 times, most recently
from
1767de4 to
7cd13c6
Compare
basil
changed the title
basil
changed the title
csp.rule is defined
basil
force-pushed
the
csp-report-only
branch
3 times, most recently
from
3a42540 to
21e7a32
Compare
basil
force-pushed
the
csp-report-only
branch
from
21e7a32 to
8860c9d
Compare
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #1743, when
csp.ruleis defined, we not only enable CSP in restrictive mode, but also we verify at the end of each test that there are no violations logged on the report page. Currently skipped for two plugins that have known violations:ArtifactoryPluginTest(tracked in JENKINS-74047)SubversionPluginTest(tracked in JENKINS-73900)