Add oic auth e2e #1705
Closed
Add oic auth e2e #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Realm.java Co-authored-by: James Nord <[email protected]>
TestContainers does not use docker, but talks directly to the docker socket. The permissions on this socket come from the host where it is mapped and the docker groupid may not match what we have in the container. So allow th arg to be passed through at build time and add the ath-user to the docker group so it has the permissions. We retain the legacy suid on the docker binary as we publish the container and there is only a single test so far using this test-containers. (this can be revistied if required).
Installing packages can create groups, and the group id used can be dynamic. As such the group we want to use may already be in use. Attempt to workaround this issue by creating the group before installaing any packages so that the group is more likely to be available.
jtnord
force-pushed
the
add-oic-auth-e2e
branch
from
af39bd8 to
818619a
Compare
remove the seuid hacks and attempt to add the docker group and replace with a call to add the user to the docker group from the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1701 with a small tweak and filed from my fork so that the Jenkinsfile changes can be picked up.
Testing done
Submitter checklist