Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Jenkinsfile) Use jenkins/ath instead of rebuilding it #1168

Merged
merged 1 commit into from
May 12, 2023

Conversation

dduportal
Copy link
Collaborator

Fixes #988

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

It's switched from previously a consistent range of
2m50 to 3m building the image

to
1m to 1m 10 pulling the image.

Further optimisation could be done to pre-pull the image to the VM image or use a container registry local to the cloud provider I suspect, but for now that's a lot better

@timja timja added the chore label May 11, 2023
@dduportal dduportal merged commit d8d38af into master May 12, 2023
@dduportal dduportal deleted the chore/pipeline/donotbuildoneachsplit branch May 12, 2023 05:01
@basil
Copy link
Member

basil commented May 23, 2023

But does this not use the last published version of the image rather than the one defined in code under test? That is not OK from a correctness perspective, because that means a change to the image made in a PR (the code under test) will not take effect in that PR. This also makes it impossible to change both the image and the consumer of the image in the same PR, which was possible before this. A better approach from a correctness perspective would be to build the image from the code under test once and then consume it from each parallel branch.

@basil
Copy link
Member

basil commented May 25, 2023

Causes #1193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't build ATH image on every split
3 participants