Add support to print information about newly upgraded Jenkins #593

jxr98 · 2021-07-18T14:01:02Z

Make sure that you've checked the boxes below before you submit PR:

Always

Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
Written well with PR title, we generate the release notes base on that

For the bug fixes or features only

codecov-commenter · 2021-07-18T14:01:47Z

Codecov Report

Merging #593 (ac7a77e) into master (9bfb8da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #593   +/-   ##
=======================================
  Coverage   37.98%   37.98%           
=======================================
  Files          13       13           
  Lines         416      416           
=======================================
  Hits          158      158           
  Misses        246      246           
  Partials       12       12

Flag	Coverage Δ
unittests	`37.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfb8da...ac7a77e. Read the comment docs.

LinuxSuRen · 2021-07-19T02:45:18Z

app/cmd/center_list_test.go

+			err = ioutil.WriteFile(rootOptions.ConfigFile, data, 0664)
+			Expect(err).To(BeNil())
+
+			resp, _ := http.Get(LTSURL)


Any real network request should not be here. We cannot guarantee all environments have internet access.

OK. I am going to change this.

jxr98 · 2021-07-19T12:09:08Z

app/cmd/center_list.go

+	"strings"
+)
+
+const LTSURL = "https://www.jenkins.io/changelog-stable/rss.xml"


OK, I have changed this part.

yJunS · 2021-07-19T14:45:41Z

app/cmd/center_list_test.go

+			err = ioutil.WriteFile(rootOptions.ConfigFile, data, 0664)
+			Expect(err).To(BeNil())
+
+			resp, _ := http.Get(LTSURL)


Where is the LTSURL value defined??

In the center_list.go. The LTSURL is a constant and I changed the name from LTSURL to LtsUrl. But I haven't changed the test file. I will have it done in a few days

yJunS · 2021-07-19T14:46:09Z

app/cmd/center_list_test.go

+			var centerListOption CenterListOption
+			xml.Unmarshal(bytes, &centerListOption)
+			theNewestJenkinsVersion := centerListOption.Channel.Items[0].Title[8:]
+			temp, _ := printChangelog(LTSURL, theNewestJenkinsVersion)


Same as above

LinuxSuRen

Hi @jxr98 , thanks for your contribution. I found some small issues. Please take a look at it. And please don't forget to check the CI status from GitHub. The status of Lint was failed.

By the way, the e2e tests have a big chance to fail. So I suggest that we can skip them for now. See also https://github.com/jenkins-zh/jenkins-cli/blob/master/.github/workflows/e2e-test.yaml

LinuxSuRen · 2021-07-25T01:34:46Z

app/cmd/center_list_test.go

@@ -1,6 +1,7 @@
 package cmd

 import (
+	bytes2 "bytes"


Why do you give it an alias bytes2?

LinuxSuRen · 2021-07-25T01:37:48Z

app/cmd/center_list_test.go

+</rss>`
+}
+
+func resultOneVersionData() string {


I don't block here. But a better way might be putting these strings into a file. Golang allows us to embed files into the binary file.

Refs

https://golang.org/pkg/embed/

https://blog.jetbrains.com/go/2021/06/09/how-to-use-go-embed-in-go-1-16/

LinuxSuRen · 2021-07-25T01:38:54Z

app/cmd/center_list.go

+//the number of lines to be printed in description column
+const NumberOfLinesOfDescription = 10
+//ASCII of line feed
+const AsciiOfLineFeed = 10


@jxr98 Please check the tips from hound.

LinuxSuRen · 2021-07-25T01:38:58Z

app/cmd/center_list.go

+//ASCII of line feed
+const AsciiOfLineFeed = 10
+//ASCII of space
+const AsciiOfSpace = 32


@jxr98 Please check the tips from hound.

jxr98 · 2021-07-25T11:45:14Z

The reason why the e2e test failed this time was the go version used by this project was 1.15, but "embed" was added in go 1.16. I am gonna find a solution.

LinuxSuRen · 2021-07-25T13:58:58Z

failed

We can use go 1.16

yJunS · 2021-07-28T10:32:50Z

The reason why the e2e test failed this time was the go version used by this project was 1.15, but "embed" was added in go 1.16. I am gonna find a solution.

If you are sure that go 1.16 version can be tested normally in e2e, we can update the test dependency version to 1.16.

yJunS · 2021-07-29T14:15:12Z

#599 I already pull request to update e2e go version

jxr98 · 2021-08-20T04:28:19Z

Hello @LinuxSuRen! Sorry to bother you. The e2e test failed again after I pulled from origin and resolved the conflict. The TestPowerShellCompletion failed and I have no idea what the reason is. Could you please give me a little hint on it? Thanks so much.

LinuxSuRen · 2021-08-20T05:43:06Z

Hello @LinuxSuRen! Sorry to bother you. The e2e test failed again after I pulled from origin and resolved the conflict. The TestPowerShellCompletion failed and I have no idea what the reason is. Could you please give me a little hint on it? Thanks so much.

Let's forget about the e2e tests for now.

jxr98 · 2021-08-21T04:13:55Z

Hello @LinuxSuRen! Sorry to bother you. The e2e test failed again after I pulled from origin and resolved the conflict. The TestPowerShellCompletion failed and I have no idea what the reason is. Could you please give me a little hint on it? Thanks so much.

Let's forget about the e2e tests for now.

All right.

LinuxSuRen · 2021-08-30T14:27:18Z

It would be better if you can tell us how to test this PR.

LinuxSuRen

I feel confused about the following output. Maybe for many users, they just don't know what they should do next. So, it would be great to have more information about your CLI:

gitpod /workspace/jenkins-cli $ ./jcli center list
Error: Get "http://localhost:8080/jenkins/api/json": dial tcp [::1]:8080: connect: connection refused

jxr98 · 2021-08-30T15:36:02Z

I feel confused about the following output. Maybe for many users, they just don't know what they should do next. So, it would be great to have more information about your CLI:
gitpod /workspace/jenkins-cli $ ./jcli center list
Error: Get "http://localhost:8080/jenkins/api/json": dial tcp [::1]:8080: connect: connection refused

I will figure this out tomorrow.

…s-zh#593)

linuxsuren-bot added the size/XL label Jul 18, 2021

LinuxSuRen reviewed Jul 19, 2021

View reviewed changes

jxr98 commented Jul 19, 2021

View reviewed changes

jxr98 changed the title ~~Add support to print information about newly upgraded plugins~~ Add support to print information about newly upgraded Jenkins Jul 19, 2021

yJunS requested changes Jul 19, 2021

View reviewed changes

LinuxSuRen requested changes Jul 25, 2021

View reviewed changes

linuxsuren-bot added size/XXL and removed size/XL labels Aug 12, 2021

LinuxSuRen requested a review from yJunS August 20, 2021 05:43

LinuxSuRen added conflicts feature labels Aug 30, 2021

jxr98 force-pushed the centerlist branch 2 times, most recently from c1108ec to b50df06 Compare August 30, 2021 13:40

LinuxSuRen requested changes Aug 30, 2021

View reviewed changes

LinuxSuRen force-pushed the centerlist branch from 9332403 to ef8ae99 Compare August 30, 2021 14:34

jxr98 added 5 commits September 1, 2021 20:23

add -tail to job log

0424f8c

Update job_log.go

1a0b71b

Add feature 'center list'

12d0e10

change job log back

f8cdb70

update center list

a88fa1d

jxr98 and others added 9 commits September 1, 2021 20:23

Update center_list.go

f98fe24

Update center_list_test.go

6ebcbbc

Update center_list.go

4d13c7f

Update center_list_test.go

cdad5fc

Add center_list.txt which contains test result example

81e884f

update feature center list

c91cf09

update go.sum

9dcaef8

update center list

18c7209

add new feature to center list

9f8a077

jxr98 force-pushed the centerlist branch from ef8ae99 to 9f8a077 Compare September 2, 2021 14:34

change some of the lint mistakes

ac7a77e

LinuxSuRen merged commit 8f2c9f0 into jenkins-zh:master Sep 3, 2021

jxr98 added a commit to jxr98/jenkins-cli that referenced this pull request Sep 4, 2021

Add support to print information about newly upgraded Jenkins (jenkin…

fc93781

…s-zh#593)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to print information about newly upgraded Jenkins #593

Add support to print information about newly upgraded Jenkins #593

jxr98 commented Jul 18, 2021 •

edited

Loading

codecov-commenter commented Jul 18, 2021 •

edited by codecov bot

Loading

LinuxSuRen Jul 19, 2021

jxr98 Jul 20, 2021

jxr98 Jul 19, 2021

yJunS Jul 19, 2021

jxr98 Jul 20, 2021

yJunS Jul 19, 2021

LinuxSuRen left a comment

LinuxSuRen Jul 25, 2021

LinuxSuRen Jul 25, 2021

LinuxSuRen Jul 25, 2021

LinuxSuRen Jul 25, 2021

jxr98 commented Jul 25, 2021

LinuxSuRen commented Jul 25, 2021

yJunS commented Jul 28, 2021

yJunS commented Jul 29, 2021

jxr98 commented Aug 20, 2021

LinuxSuRen commented Aug 20, 2021

jxr98 commented Aug 21, 2021

LinuxSuRen commented Aug 30, 2021

LinuxSuRen left a comment

jxr98 commented Aug 30, 2021

Add support to print information about newly upgraded Jenkins #593

Add support to print information about newly upgraded Jenkins #593

Conversation

jxr98 commented Jul 18, 2021 • edited Loading

Always

For the bug fixes or features only

codecov-commenter commented Jul 18, 2021 • edited by codecov bot Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LinuxSuRen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Refs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jxr98 commented Jul 25, 2021

LinuxSuRen commented Jul 25, 2021

yJunS commented Jul 28, 2021

yJunS commented Jul 29, 2021

jxr98 commented Aug 20, 2021

LinuxSuRen commented Aug 20, 2021

jxr98 commented Aug 21, 2021

LinuxSuRen commented Aug 30, 2021

LinuxSuRen left a comment

Choose a reason for hiding this comment

jxr98 commented Aug 30, 2021

jxr98 commented Jul 18, 2021 •

edited

Loading

codecov-commenter commented Jul 18, 2021 •

edited by codecov bot

Loading