Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split command creates a new repo as public #7557

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

drorventura
Copy link

@drorventura drorventura commented Sep 7, 2020

relates to issue #7535

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot
Copy link
Contributor

Hi @drorventura. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@drorventura
Copy link
Author

/assign @daveconde

@drorventura
Copy link
Author

/test ?

@drorventura
Copy link
Author

/assign @jstrachan

@drorventura
Copy link
Author

/unassign @daveconde

@drorventura
Copy link
Author

/assign @rawlingsj

@drorventura
Copy link
Author

/assign @garethjevans

@drorventura
Copy link
Author

/assign @daveconde

@drorventura
Copy link
Author

/assign @pmuir

@drorventura
Copy link
Author

Hi everyone!
Do you know who should I Assign for this very small fix to be approved for testing?

Thanks,
@MarckK @jstrachan @pmuir @garethjevans @rawlingsj @daveconde

@rawlingsj
Copy link
Member

/ok-to-test
/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 38e4f64 into jenkins-x:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants