feat: adds a command to generate a helmfile.yaml from a j… #6623
Conversation
pkg/cmd/experiment/create/create.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| create_long = templates.LongDesc(` |
There was a problem hiding this comment.
don't use underscores in Go names; var create_long should be createLong
| ShowLogs bool `json:"showlogs"` | ||
| } | ||
|
|
||
| // Environment |
There was a problem hiding this comment.
comment on exported type Environment should be of the form "Environment ..." (with optional leading article)
| Environment SubhelmfileEnvironmentSpec | ||
| } | ||
|
|
||
| type SubhelmfileEnvironmentSpec struct { |
There was a problem hiding this comment.
exported type SubhelmfileEnvironmentSpec should have comment or be unexported
| Repositories []RepositorySpec `json:"repositories,omitempty"` | ||
| Releases []ReleaseSpec `json:"releases,omitempty"` | ||
| Selectors []string `json:"-"` | ||
| ApiVersions []string `json:"apiVersions,omitempty"` |
There was a problem hiding this comment.
struct field ApiVersions should be APIVersions
pkg/cmd/experiment/create/create.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| create_long = templates.LongDesc(` |
There was a problem hiding this comment.
don't use underscores in Go names; var create_long should be createLong
pkg/cmd/experiment/experiment.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| create_long = templates.LongDesc(` |
There was a problem hiding this comment.
don't use underscores in Go names; var create_long should be createLong
| ShowLogs bool `json:"showlogs"` | ||
| } | ||
|
|
||
| // Environment |
There was a problem hiding this comment.
comment on exported type Environment should be of the form "Environment ..." (with optional leading article)
| Environment SubhelmfileEnvironmentSpec | ||
| } | ||
|
|
||
| type SubhelmfileEnvironmentSpec struct { |
There was a problem hiding this comment.
exported type SubhelmfileEnvironmentSpec should have comment or be unexported
| Repositories []RepositorySpec `json:"repositories,omitempty"` | ||
| Releases []ReleaseSpec `json:"releases,omitempty"` | ||
| Selectors []string `json:"-"` | ||
| ApiVersions []string `json:"apiVersions,omitempty"` |
There was a problem hiding this comment.
struct field ApiVersions should be APIVersions
…x-applications.yml this is an experimenal feature which uses a seperate jx-apps.yml file to incorporate adding apps to a boot install. relates to #6442 Signed-off-by: James Rawlings <[email protected]>
rawlingsj
changed the title
|
@rawlingsj I guess the primary user of this command would be the |
yeah good call, lemme do that now |
…ep one Signed-off-by: James Rawlings <[email protected]>
rawlingsj
changed the title
|
/retest |
Signed-off-by: James Rawlings <[email protected]>
|
/retest |
|
/lgtm - great stuff! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstrachan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…x-apps.yml
this is an experimental feature which is isolated, if the idea matures then we may want to add the application types to a jx-requirements.yaml and remove the use of jx-apps.yml. The reason that's not done here is so that we don't let the experiment affect existing core functionality.
I've also included a top level experiment command we can add these types of labs efforts to make it clear they are experimental and will likely change.
example usage:
relates to the app extensions for boot enhancement and issue #6442
Signed-off-by: James Rawlings [email protected]