Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set .Requirements.repository by default to "nexus" #6013

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Nov 2, 2019

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

The helm charts in jenkins-x-boot-config need to check this value a bunch of times, so it'd be awkward to tweak them to always do a hasKey check first. So let's set this by default to "nexus" - can't go with "" as the default because the field is omitempty.

Fixes version stream BDD failures like:

STEP: install-jenkins-x command: /bin/sh -c ** step helm apply --boot --remote --name jenkins-x --provider-values-dir ../kubeProviders in dir: /workspace/source/boot-source/env
Modified file /workspace/source/boot-source/env/Chart.yaml to set the chart to version 1
error: generating values.yaml for tree from /tmp/**-helm-apply-164375805/env: failed to execute Secrets template: /tmp/**-helm-apply-164375805/env/bucketrepo/values.tmpl.yaml: template: values.tmpl.yaml:1:23: executing "values.tmpl.yaml" at <.Requirements.repository>: map has no entry for key "repository"
error: failed to interpret pipeline file jenkins-x.yml: failed to run '/bin/sh -c ** step helm apply --boot --remote --name jenkins-x --provider-values-dir ../kubeProviders' command in directory 'env', output: ''
ERROR: Error: Command failed  ** boot -b
error: exit status 1

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #6011

The helm charts in `jenkins-x-boot-config` need to check this value a
bunch of times, so it'd be awkward to tweak them to always do a
`hasKey` check first. So let's set this by default to `"nexus"` -
can't go with `""` as the default because the field is `omitempty`.

Signed-off-by: Andrew Bayer <[email protected]>
@abayer
Copy link
Contributor Author

abayer commented Nov 2, 2019

/test integration

@rawlingsj
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abayer added a commit to jenkins-x-bot/jenkins-x-versions that referenced this pull request Nov 2, 2019
Won't pass otherwise. We'll remove this once
jenkins-x/jx#6013 has gotten through the
version stream and the explicit specification of `repository` isn't
needed any more.

Signed-off-by: Andrew Bayer <[email protected]>
@abayer
Copy link
Contributor Author

abayer commented Nov 2, 2019

/retest

@jenkins-x-bot jenkins-x-bot merged commit 6f8fa12 into jenkins-x:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jx boot throws up on <.Requirements.repository>
3 participants