Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: EXPERIMENT: Forcing a clone of boot config in boot-vault call to boot #5936

Closed
wants to merge 13 commits into from
Closed

WIP: EXPERIMENT: Forcing a clone of boot config in boot-vault call to boot #5936

wants to merge 13 commits into from

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Oct 24, 2019 •
edited
Loading

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Issues like #5929 make me suspect that there are bugs that are encountered when jx boot needs to clone jenkins-x-boot-config rather than operating in an already-existing clone. So I'm trying to reproduce that here. Let's see what happens.

EDIT: I also decided to reproduce that issue more thoroughly by checking out an older version of jenkins-x-versions before running boot...

Special notes for the reviewer(s)

Which issue this PR fixes

n/a

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: abayer

If they are not already assigned, you can assign the PR to them by writing /assign @abayer in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abayer abayer force-pushed the is-version-stream-clone-verifying-remote branch from 9d7c02f to 2205aef Compare October 24, 2019 20:23
@abayer
WIP: EXPERIMENT: Forcing a clone of boot config in boot-vault calling…
76e9373 
… boot

Issues like jenkins-x#5929 make me suspect that there are bugs that are
encountered when `jx boot` needs to clone `jenkins-x-boot-config`
rather than operating in an already-existing clone. So I'm trying to
reproduce that here. Let's see what happens.

Signed-off-by: Andrew Bayer <[email protected]>
@abayer abayer force-pushed the is-version-stream-clone-verifying-remote branch from 2205aef to 76e9373 Compare October 24, 2019 20:29
@abayer
forcing non-fast-forward
57452d6 
Signed-off-by: Andrew Bayer <[email protected]>
@abayer
Copy link
Contributor Author

abayer commented Oct 25, 2019

/retest

@abayer
Copy link
Contributor Author

abayer commented Oct 25, 2019

/test boot-vault

@abayer
Copy link
Contributor Author

abayer commented Oct 25, 2019

/retest

@abayer
Copy link
Contributor Author

abayer commented Oct 25, 2019

/retest

@jenkins-x-bot
Copy link
Contributor

@abayer: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
boot-vault 49da103 link /test boot-vault

View all Builds for this Pull Request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abayer abayer closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethjevans garethjevans Awaiting requested review from garethjevans

@jstrachan jstrachan Awaiting requested review from jstrachan

Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abayer @jenkins-x-bot