Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR pipelines to run helmfile diff #6672

Closed
jstrachan opened this issue Jan 31, 2020 · 6 comments
Closed

PR pipelines to run helmfile diff #6672

jstrachan opened this issue Jan 31, 2020 · 6 comments
Labels
area/helmfile kind/enhancement An enhancement of an existing feature lifecycle/rotten

Comments

@jstrachan
Copy link
Member

it would be awesome if PRs on a helmfile based environment git repository would run helmfile diff and post the results to the PR as a comment. Then folks could see the effect of PRs before merge

@jstrachan jstrachan added kind/enhancement An enhancement of an existing feature area/helmfile labels Jan 31, 2020
@vbehar
Copy link

vbehar commented Feb 3, 2020

FYI in our current setup based on helmfile, we are running the following steps for each PR:

  • helmfile deps
  • helmfile lint --skip-deps
  • helmfile diff --skip-deps --suppress-secrets
  • helmfile template --skip-deps | kubectl apply --dry-run -f -

@jstrachan
Copy link
Member Author

logging the diff in the master pipeline would be handy too for diagnostics

@jenkins-x-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

@jenkins-x-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

@jenkins-x-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

@jenkins-x-bot
Copy link
Contributor

@jenkins-x-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helmfile kind/enhancement An enhancement of an existing feature lifecycle/rotten
Projects
None yet
Development

No branches or pull requests

3 participants