fix: verify-preinstall

[ww-daniel-mora]

This change should address jenkins-x/jx#5786 where preinstall is using the wrong kubeProviders directory.

[jenkins-x-bot]

Hi @ww-daniel-mora. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bigfleet]

Applying this patch did get me farther along in my jenkinsx install, but I did get another subsequent error farther along.

[✖]  unable to delete iamserviceaccount(s) without IAM OIDC provider enabled
error: error creating the IRSA managed Service Accounts: failure creating the IRSA managed service accounts: there was a problem deleting IAM ServiceAccounts: there was a problem calling eksctl with the provided args: failed to run 'eksctl delete iamserviceaccount --config-file /var/folders/ch/nmc2vp0j3tn9v0c_s1jt6gf80000gn/T/irsa-template-052989718 --include="*" --approve --wait' command in directory '', output: ''
error: failed to interpret pipeline file jenkins-x.yml: failed to run '/bin/sh -c jx step verify preinstall --provider-values-dir="kubeProviders"' command in directory '.', output: ''

[andrewhertog]

As with @bigfleet, i get further along, but with the following error:

[✖]  no eksctl-managed CloudFormation stacks found for "andrew-test-dev"
error: error creating the IRSA managed Service Accounts: failure creating the IRSA managed service accounts: there was a problem deleting IAM ServiceAccounts: there was a problem calling eksctl with the provided args: failed to run 'eksctl delete iamserviceaccount --config-file /var/folders/7j/1q2v50xj5s36h58tzl5ym5lw0000gn/T/irsa-template-551279021 --include="*" --approve --wait' command in directory '', output: ''
error: failed to interpret pipeline file jenkins-x.yml: failed to run '/bin/sh -c jx step verify preinstall --provider-values-dir="kubeProviders"' command in directory '.', output: ''

[ww-daniel-mora]

@bigfleet @andrewhertog strangely I did not run into that issue. Could you try with an IAM user with more permissions? I would like to rule that out as a possibility before investigating further.

[andrewhertog]

@ww-daniel-mora is it possible to skip the IRSA steps?

[andrewhertog]

@bigfleet @andrewhertog strangely I did not run into that issue. Could you try with an IAM user with more permissions? I would like to rule that out as a possibility before investigating further.

The IAM user running on my local machine has full admin access to the AWS account.

[andrewhertog]

One thing I've noticed is that no eksctl-managed CloudFormation stacks found for "andrew-test-dev"

My cluster was spun up manually via a terraform module, not with eksctl. Could this be why? Does JX assume all EKS clusters are spun up via eksctl?

[andrewhertog]

@ww-daniel-mora I just gave the role on my EKS cluster adminstrator access, and I'm using an aws account on my machine where i am running jx boot with administrator access to AWS.
I am still getting the same error:

attempting to lazily create the IAM Role for Service Accounts permissions
Enabling IRSA for cluster andrew-test-dev associating the IAM Open ID Connect provider
[ℹ]  using region us-east-1
[ℹ]  IAM Open ID Connect provider is already associated with cluster "andrew-test-dev" in "us-east-1"
Creating CloudFormation stack JenkinsXPolicies-9279cbef-c44d-43d9-af17-b30d5a64a2df
Waiting until CloudFormation stack JenkinsXPolicies-9279cbef-c44d-43d9-af17-b30d5a64a2df is created
Describing stack JenkinsXPolicies-9279cbef-c44d-43d9-af17-b30d5a64a2df to extract outputs
Deleting IRSA ServiceAccounts
[ℹ]  using region us-east-1
[ℹ]  comparing 2 iamserviceaccounts defined in the given config ("/var/folders/7j/1q2v50xj5s36h58tzl5ym5lw0000gn/T/irsa-template-627997571") against remote state
[✖]  no eksctl-managed CloudFormation stacks found for "andrew-test-dev"
error: error creating the IRSA managed Service Accounts: failure creating the IRSA managed service accounts: there was a problem deleting IAM ServiceAccounts: there was a problem calling eksctl with the provided args: failed to run 'eksctl delete iamserviceaccount --config-file /var/folders/7j/1q2v50xj5s36h58tzl5ym5lw0000gn/T/irsa-template-627997571 --include="*" --approve --wait' command in directory '', output: ''
error: failed to interpret pipeline file jenkins-x.yml: failed to run '/bin/sh -c jx step verify preinstall --provider-values-dir="kubeProviders"' command in directory '.', output: ''

Note: this isn't the full output, but just the relevant portion of it.

[andrewhertog]

I managed to get further. I was missing the terraform: true value in the jx-requirements.yaml file.

[babadofar]

I'm stranded on the same desolate island as #81 (comment) Please let there be pineapples here

[jstrachan]

/lgtm

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jstrachan]

/ok-to-test