Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set GitURL on env to group auto promotions on same repo #406

Merged

Conversation

gazal-k
Copy link
Contributor

@gazal-k gazal-k commented Sep 13, 2022

The feature to promote multiple auto environments using the same promote PR (original change: #216) may have been broken by #236. Add a line to set the derived sourceURL to env.GitURL so that it can be matched against when grouping environments.

re #400

The feature to promote multiple auto environments using the same promote PR (original change: jenkins-x-plugins#216) may have been broken by jenkins-x-plugins#236. Add a line to set the derived `sourceURL` to `env.GitURL` so that it can be matched against when grouping environments.

re jenkins-x-plugins#400
@jenkins-x-bot
Copy link
Contributor

Hi @gazal-k. Thanks for your PR.

I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ankitm123
Copy link
Contributor

/ok-to-test

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 045983a into jenkins-x-plugins:main Sep 13, 2022
@gazal-k gazal-k deleted the gazal/group-auto-promotions branch September 13, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants