Further limit allowed characters in file path #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
added
the
enhancement
zbynek
reviewed
Mar 1, 2023
src/main/java/io/jenkins/update_center/ArtifactoryRepositoryImpl.java
Outdated
Show resolved
Hide resolved
zbynek
approved these changes
Mar 1, 2023
Co-authored-by: Zbynek Konecny <[email protected]>
NotMyFault
approved these changes
Mar 3, 2023
daniel-beck
added a commit
to daniel-beck/update-center2
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #364 and #673.
This filters out paths that include a bunch of characters that indicate something has gone wrong during the Maven release process. While there are already several characters (notably unprintable ASCII, originally motivating this filter) being filtered, this adds more, based on what is actually used: Keep basic ASCII letters, digits,
_+.-, as well as/since we're looking at paths at this point.Compared to the current filter, this doesn't remove anything that is being distributed at the moment.
Also fix the message, it hasn't been correct in a long time, most of the stuff filtered is due to
%from percent-encoded characters.