Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CD on instance-identity #2620

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Enable CD on instance-identity #2620

merged 1 commit into from
Jun 28, 2022

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Jun 28, 2022

Description

Was reluctant to do this earlier since it makes it slightly more work to prefile PRs like jenkins-infra/update-center2#594 or jenkins-infra/update-center2#601 but those should no longer be necessary after jenkinsci/instance-identity-plugin#25. @timja @jtnord et al.

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@jglick jglick requested a review from a team as a code owner June 28, 2022 13:08
@timja timja merged commit 2787213 into jenkins-infra:master Jun 28, 2022
@jglick jglick deleted the patch-1 branch June 28, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants