Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section about operating system specific tests #7755

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Add section about operating system specific tests #7755

merged 3 commits into from
Dec 15, 2024

Conversation

StefanSpieker
Copy link
Contributor

Add section about operating system specific tests,
after reading the old Wiki Unit+Test+on+Windows

@StefanSpieker StefanSpieker requested a review from a team as a code owner December 15, 2024 13:10
@probot-autolabeler probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label Dec 15, 2024
MarkEWaite
MarkEWaite approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very, very much! Approved.

I've included some suggestions, but all of my suggestions are optional. Approved even if none of the suggestions are included.

content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
content/doc/developer/testing/index.adoc Outdated Show resolved Hide resolved
@StefanSpieker
Copy link
Contributor Author

Thanks a lot @MarkEWaite for the nice suggestions.

krisstern
krisstern approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@MarkEWaite MarkEWaite merged commit c9bb3d5 into jenkins-infra:master Dec 15, 2024
6 checks passed
@StefanSpieker StefanSpieker deleted the operating_system branch December 15, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbynek zbynek zbynek left review comments

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@krisstern krisstern krisstern approved these changes

Assignees
No one assigned
Labels
documentation Jenkins documentation, including user and developer docs, solution pages, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StefanSpieker @MarkEWaite @zbynek @krisstern