Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included Unix domain sockets in Reverse proxy - Pomerium #7752

Conversation

biru-codeastromer
Copy link
Contributor

@biru-codeastromer biru-codeastromer commented Dec 14, 2024

ISSUE: Update Pomerium reverse proxy documentation to include support for unix domain sockets #6893

This pull request updates the documentation regarding the usage and behavior of Unix domain sockets in Reverse Proxy-Pomerium. The following changes have been made:

1.Clarified the explanation of how Unix domain sockets work within the system.
2.Included examples of common use cases and code snippets to help developers implement Unix domain sockets effectively.
3.Updated relevant sections to reflect the latest changes in the codebase and best practices for socket management.
4.These changes aim to enhance the clarity of the documentation, making it easier for developers to understand and work with Unix domain sockets

Hi Sir @kmartens27 .Please review the changes, and let me know if any further updates are required.

@biru-codeastromer biru-codeastromer requested a review from a team as a code owner December 14, 2024 10:14
@probot-autolabeler probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label Dec 14, 2024
@biru-codeastromer biru-codeastromer deleted the include-unix-domain-sockets branch December 14, 2024 10:33
@biru-codeastromer biru-codeastromer restored the include-unix-domain-sockets branch December 14, 2024 10:40
@MarkEWaite
Copy link
Contributor

@biru-codeastromer have you tested these changes and confirmed that they work as expected? Can you describe that testing in more detail as part of the pull request description?

If you haven't tested the changes, then please test them. We don't want to publish a documentation page that has not been tested to assure that the modified instructions work as expected.

@biru-codeastromer
Copy link
Contributor Author

Sure Sir @MarkEWaite I will be modifying my pull request description and add more details of testing. Thank you for helping me!

@biru-codeastromer biru-codeastromer deleted the include-unix-domain-sockets branch December 15, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Jenkins documentation, including user and developer docs, solution pages, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants