Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins LTS 2.426.1 - creating changelog & upgrade guide #6802

Merged
merged 17 commits into from
Nov 9, 2023
Merged

Jenkins LTS 2.426.1 - creating changelog & upgrade guide #6802

merged 17 commits into from
Nov 9, 2023

Conversation

kmartens27
Copy link
Contributor

This pull request is for the creation of the changelog & upgrade guide for Jenkins.

The items that are currently listed in the backporting ticket have been included, as well a potential entry for the drag & drop repeatable fix.

There will be edits made to both the changelog & upgrade guide in the following days, as there may be additional entries that need to have upgrade guide entries added.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @kmartens27 !

I've made a few comments that I think need to be corrected.

I need to do some further research on the security fixes that were backported. Since they were applied to 2.414.3 and this is the next LTS line after 2.414.3, I'm not sure if they need to be mentioned here or not.

@daniel-beck can you guide us whether it is better to mention the backported security fix (HTTP/2 rapid reset with Jetty) in the 2.426.1 changelog or if it is better to leave it unmentioned. I don't recall a previous release where we had that case, so I'm not sure how to find the previous changelog for reference.

content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
Add upgrade guide entry for RHEL 7 end of support along with the
changelog entry.
@daniel-beck
Copy link
Contributor

daniel-beck commented Nov 7, 2023

can you guide us whether it is better to mention the backported security fix (HTTP/2 rapid reset with Jetty) in the 2.426.1 changelog or if it is better to leave it unmentioned. I don't recall a previous release where we had that case, so I'm not sure how to find the previous changelog for reference.

https://www.jenkins.io/changelog-stable/#v2.414.1 was essentially the same situation. Or why would it not apply here as well?

(In general, IMO, every backported change gets a changelog entry. If it's important enough to backport, it's important enough to mention. If the original change didn't have a changelog entry, it should now get one, for the same reason: Turns out it was more important than it looked like at the time.)

@MarkEWaite
Copy link
Contributor

https://www.jenkins.io/changelog-stable/#v2.414.1 was essentially the same situation. Or why would it not apply here as well?

(In general, IMO, every backported change gets a changelog entry. If it's important enough to backport, it's important enough to mention. If the original change didn't have a changelog entry, it should now get one, for the same reason: Turns out it was more important than it looked like at the time.)

Thanks. That's a great answer and a reminder that we had the same situation very recently. The current changelog follows the same pattern as was used for 2.414.1. No change needed for the security mention that is already included in the changelog.

@MarkEWaite MarkEWaite self-requested a review November 7, 2023 21:48
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments for consideration.

content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two optional removals for your consideration. I think they should be removed because they are not visible to users.

content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another change to fix a mistake I made earlier.

content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
@MarkEWaite
Copy link
Contributor

@kmartens27 once we have the changelog entry for the SnakeYAML 2.2 update, I think this will be ready to merge.

@kmartens27
Copy link
Contributor Author

I've just added the entry for SnakeYAML, classifying it as a regression (since it's part of the 2.431 weekly).

content/_data/changelogs/lts.yml Outdated Show resolved Hide resolved
@MarkEWaite MarkEWaite enabled auto-merge (squash) November 9, 2023 22:04
@MarkEWaite MarkEWaite merged commit c2fc223 into jenkins-infra:master Nov 9, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Jenkins changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants