-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JEP-237] Introduce initial documentation for FIPS-140 #6675
Conversation
Adds developer facing documentation to allow them to better understand what constitutes compliant vs non compliant code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admonition does not render correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much! The broken link from the system properties page needs to be fixed. All the other review comments are optional.
Co-authored-by: Mark Waite <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I gave bad advice earlier on removing a level 1 heading. Fixed my mistake in 4c78074 |
updatecli ->
🤷 |
Transient failure that I'm ignoring. Merging now. |
* script update for prototype js removal (jenkins-infra#6730) * script update for prototype js removal * script update for prototype js removal * Update content/blog/2023/05/12/2023-05-12-removing-prototype-from-jenkins.adoc Co-authored-by: Zbynek Konecny <[email protected]> --------- Co-authored-by: Zbynek Konecny <[email protected]> * Update dependency bootstrap to v5.3.2 (jenkins-infra#6727) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Automated changelog for 2.426 (jenkins-infra#6707) * Automated changelog for 2.426 * Edits to fix layout * Link to JEP-237 * Add docker container entry to 2.426 changelog * Fix 2.426 release date --------- Co-authored-by: jenkins-infra-changelog-generator <86592549+jenkins-infra-changelog-generator[bot]@users.noreply.github.com> Co-authored-by: Mark Waite <[email protected]> * [JEP-237] Introduce initial documentation for FIPS-140 (jenkins-infra#6675) * [JEP-237] Introduce initial administration documentation for FIPS-140 Add user facing documentation for https://github.com/jenkinsci/jep/blob/master/jep/237/README.adoc * [JEP-237] Introduce initial developer documentaion for FIPS-130 Adds developer facing documentation to allow them to better understand what constitutes compliant vs non compliant code. * Apply suggestions from code review Co-authored-by: Anita Manders <[email protected]> Co-authored-by: Raúl Arabaolaza Barquin <[email protected]> * [JEP-237] add example and document KeyStore * Apply suggestions from code review Co-authored-by: Julie Heard <[email protected]> * Apply suggestions from code review Co-authored-by: Anita Manders <[email protected]> * fix indentation * add admonition * tweaks and s/FIPS/FIPS-140/ * rework note on using libraries * Fix admonition * fix link to system property * update some more links * Apply suggestions from Mark Waite Co-authored-by: Mark Waite <[email protected]> * Add level 1 heading that I mistakenly suggested for removal * Remove trailing blank from new content * Removing trailing blank from new content --------- Co-authored-by: Anita Manders <[email protected]> Co-authored-by: Raúl Arabaolaza Barquin <[email protected]> Co-authored-by: Julie Heard <[email protected]> Co-authored-by: Kevin Martens <[email protected]> Co-authored-by: Mark Waite <[email protected]> * [Python Tutorial] Bump Python alpine docker image version to 3.12.0-alpine3.18 (jenkins-infra#6733) * chore: Update the value of the python docker image for pipelines in t... ... he 'Hello World!' tutorial Made with ❤️️ by updatecli * chore: Update the value of the python docker image for scripts in the... ... 'build-a-python-app-with-pyinstaller.adoc' tutorial Made with ❤️️ by updatecli * chore: Update the value of the python docker image for scripts in the... ... 'Hello World!' tutorial Made with ❤️️ by updatecli --------- Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * Update dependency faraday to v2.7.11 (jenkins-infra#6734) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency rss to v0.3.0 (jenkins-infra#6737) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency crate-ci/typos to v1.16.17 (jenkins-infra#6738) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update jenkinsciinfra/builder Docker tag to v2.2.68 (jenkins-infra#6735) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(dependencies): Tracks Jenkins' three last LTS versions. (jenkins-infra#6717) * feat(scripts): Gets the last three LTS releases. * feat(scripts): Gets the last three LTS releases. * fix(scripts): Comments * feat(dependencies): Tracks and updates last three Jenkins LTS versions. * feat(dependencies): Tracks and updates last three Jenkins LTS versions. * feat(dependencies): Tracks last 3 Jenkins' LTS releases. * fix(dependencies): Messages are now more accurate. * fix(dependencies): Posix, mi amor. * fix(dependencies): Posix, mon amour. * fix(dependencies): No need to "x" the script anymore. * fix(dependencies): Removed core-baseline * fix(dependencies): Removes the core-baseline layout. * Update choosing-jenkins-baseline.adoc * Update update-base-jenkins-version.adoc --------- Co-authored-by: Kevin Martens <[email protected]> * Update jenkinsciinfra/builder Docker tag to v3 (jenkins-infra#6740) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bump Jenkins LTS versions to 2.414.2 in various parts of the documentation (jenkins-infra#6744) * chore: Bump Jenkins minimum BOM artifact version in the "dependency m... ... anagement" page Made with ❤️️ by updatecli * chore: Bump Jenkins minimum BOM artifact in the "plugin-bill-of-mater... ... ials" page Made with ❤️️ by updatecli * chore: Bump Jenkins minimum BOM artifact version in the "plugin-bill-... ... of-materials" page Made with ❤️️ by updatecli * chore: Bump Jenkins minimum BOM artifact in the "dependency managemen... ... t" page Made with ❤️️ by updatecli --------- Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * Update node.js from 18.x to 20.x (jenkins-infra#6741) * Add redirect for `hudson.model.UsageStatistics.disabled` property (jenkins-infra#6745) Co-authored-by: Daniel Beck <[email protected]> * [Hello World Tutorial] Bump Golang alpine docker image version to 1.21.2-alpine3.18 (jenkins-infra#6746) chore: Update the value of the golang docker image for pipelines in t... ... he 'Hello World!' tutorial Made with ❤️️ by updatecli Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * Remove link to private topic in community (jenkins-infra#6748) Remove link to private community thread The organizers of the 2021 Hacktoberfest project to localize in French are not participating in HAcktoberfest 2023 in Jenkins. The thread in community.jenkins.io was made private at the end of the 2021 effort. The remaining links are useful and the French localization effort is still a good effort to continue. * Restore placeholder calculation for version selection page (jenkins-infra#6751) Calculate placeholders in the baseline selection file Removing the placeholder processing left placeholder text. Fixes jenkins-infra#6748 * Bump Jenkins LTS versions to 2.414.2 in various parts of the documentation (jenkins-infra#6750) * chore: Bump Jenkins minimum BOM artifact version in the "plugin-bill-... ... of-materials" page Made with ❤️️ by updatecli * chore: Bump Jenkins minimum BOM artifact version in the "dependency m... ... anagement" page Made with ❤️️ by updatecli * chore: Bump Jenkins minimum BOM artifact version in the "improve a pl... ... ugin tutorial" Made with ❤️️ by updatecli --------- Co-authored-by: GitHub Actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(documentation): corebaseline is also used for other versions than LTS. (jenkins-infra#6752) We have to keep it until we address the other uses. * Add "Prototype removed" blog post (jenkins-infra#6742) * Add "Prototype removed" blog post * Update publication date --------- Co-authored-by: Mark Waite <[email protected]> --------- Co-authored-by: Dmitry Platonov <[email protected]> Co-authored-by: Zbynek Konecny <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: jenkins-infra-changelog-generator[bot] <86592549+jenkins-infra-changelog-generator[bot]@users.noreply.github.com> Co-authored-by: Mark Waite <[email protected]> Co-authored-by: James Nord <[email protected]> Co-authored-by: Anita Manders <[email protected]> Co-authored-by: Raúl Arabaolaza Barquin <[email protected]> Co-authored-by: Julie Heard <[email protected]> Co-authored-by: Kevin Martens <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bruno Verachten <[email protected]> Co-authored-by: Alexander Brandes <[email protected]> Co-authored-by: Daniel Beck <[email protected]> Co-authored-by: Daniel Beck <[email protected]> Co-authored-by: Basil Crow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit late, but I still reviewed it, nothing to said, it's fine!
Add user and developer facing documentation for https://github.com/jenkinsci/jep/blob/master/jep/237/README.adoc