[JENKINS-60866] Add initial guidelines how to make code compatible with CSP #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
documentation
daniel-beck
commented
Jul 21, 2022
12 tasks
MarkEWaite
approved these changes
Jul 21, 2022
dwnusbaum
approved these changes
Jul 21, 2022
| To parse JSON, use `JSON.parse` instead. | ||
| See https://github.com/jenkinsci/jenkins/pull/6868[jenkinsci/jenkins#6868] for an example. | ||
|
|
||
| To invoke a callback, have the caller define a global function and pass its name as an argument. |
There was a problem hiding this comment.
Having to define globals seems awkward. Do you have an example of this case?
There was a problem hiding this comment.
var foo = function() { … } (or let foo = function() { … }) outside any block makes it global scoped (or, since it's functions, function foobar() { … }).
There was a problem hiding this comment.
Yeah, I just meant that the general scenario of when you would need to do this is not really clear to me.
There was a problem hiding this comment.
It's the part of jenkinsci/jenkins#6865 related to renderOnDemand.jelly.
Co-authored-by: Devin Nusbaum <[email protected]>
|
I think this is enough of an improvement to justify the merge, especially with the review from @dwnusbaum |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better than nothing I guess?
Preview: https://deploy-preview-5301--jenkins-io-site-pr.netlify.app/doc/developer/security/csp/