Automated changelog for 2.335 #4909

jenkins-infra-changelog-generator · 2022-02-09T13:56:46Z

Created by generate-changelog.rb
Co-ordinated by generate-weekly-changelog.sh
Report an issue

dheerajodha

Some language-related suggestions.

dheerajodha · 2022-02-14T13:24:03Z

content/_data/changelogs/weekly.yml

+          - NotMyFault
+        pr_title: "[JENKINS-67742] Replace computer-flash gif"
+        message: |-
+          Replace computer-flash gif icon with hourglass


Suggested change

Replace computer-flash gif icon with hourglass

Replace the computer-flash GIF icon with the hourglass icon.

Applied to jenkinsci/jenkins#6254 pull request description. Thanks!

dheerajodha · 2022-02-14T13:30:04Z

content/_data/changelogs/weekly.yml

+          - basil
+        pr_title: Adapt to jenkinsci/remoting#490
+        message: |-
+          Remove support for <code>RoleChecker#check(RoleSensitive)</code> calls added in Jenkins 2.319 again. All remoting <code>Callable</code> implementations need to perform an actual role check as documented at https://www.jenkins.io/doc/developer/security/remoting-callables/


Suggested change

Remove support for <code>RoleChecker#check(RoleSensitive)</code> calls added in Jenkins 2.319 again. All remoting <code>Callable</code> implementations need to perform an actual role check as documented at https://www.jenkins.io/doc/developer/security/remoting-callables/

Remove support for <code>RoleChecker#check(RoleSensitive)</code> calls which were added again in Jenkins 2.319. All remoting <code>Callable</code> implementations need to perform an actual role check as documented at https://www.jenkins.io/doc/developer/security/remoting-callables/

I tried to understand the context, but I might be wrong.

Applied to the pull request description of jenkinsci/jenkins#5901

dheerajodha · 2022-02-14T13:30:24Z

content/_data/changelogs/weekly.yml

+          - janfaracik
+        pr_title: Add support for Ionicons (symbols) to <l:Icon> and <l:task> components
+        message: |-
+          Several icons across Jenkins have been updated - the build icon, the delete icon, the settings icon, the about icon and the plugin icon


Suggested change

Several icons across Jenkins have been updated - the build icon, the delete icon, the settings icon, the about icon and the plugin icon

Several icons across Jenkins have been updated - the build icon, the delete icon, the settings icon, the about icon, and the plugin icon.

Added to jenkinsci/jenkins#6186

dheerajodha · 2022-02-14T13:33:30Z

content/_data/changelogs/weekly.yml

+          - janfaracik
+        pr_title: Polish forms components and split out CSS files
+        message: |-
+          Minor form and spacing changes


Suggested change

Minor form and spacing changes

Minor form and spacing changes.

Updated in jenkinsci/jenkins#6259

dheerajodha · 2022-02-14T13:45:33Z

content/_data/changelogs/weekly.yml

+          - NotMyFault
+        pr_title: "[JENKINS-67609] Deduplicate help button question mark"
+        message: |-
+          Set the question mark on the new help button only once so that it is not shown twice when using different themes.


Suggested change

Set the question mark on the new help button only once so that it is not shown twice when using different themes.

Render the question mark on the new help button only once, even while using different themes.

Suggested change

Set the question mark on the new help button only once so that it is not shown twice when using different themes.

Render the question mark on the new help button only once so that it is not shown twice while using different themes.

Maybe?

Updated in jenkinsci/jenkins#6233

dheerajodha

Some suggestions, that can be incorporated after the release.

dheerajodha · 2022-02-14T13:48:42Z

content/_data/changelogs/weekly.yml

+          - dependabot[bot]
+          - basil
+        pr_title: 'Winstone 5.22: Bump Jetty from 9.4.43.v20210629 to 9.4.45.v20220203'
+        message: |-


Not sure how this needs to be formatted in order to look as intended in the changelog.
Plus, this is a "developer"-category entry, so needs to be added as the last entry

Will need to be moved into the correct location and have additional links after the release is complete. Attempted some formatting changes in jenkinsci/jenkins#6262, more likely needed after the release

@MarkEWaite action item after the weekly release has been delivered.

dheerajodha · 2022-02-14T13:48:56Z

content/_data/changelogs/weekly.yml

+               Append to log file rather than truncating it (https://github.com/jenkinsci/winstone/pull/200)
+               Write log file and access logs in UTF-8 encoding rather than default encoding (https://github.com/jenkinsci/winstone/pull/200)
+             Jetty 9.4.45 changelog: https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.45.v20220203
+      - &1


Needs to be removed

@MarkEWaite action item after release is available

dheerajodha · 2022-02-14T13:49:09Z

content/_data/changelogs/weekly.yml

+        pr_title: Modernise form components
+        message: |-
+          Modernise form components.
+      - *1


Needs to be removed.

@MarkEWaite action item after release is available

dheerajodha · 2022-02-14T13:51:32Z

content/_data/changelogs/weekly.yml

+        pr_title: "[JENKINS-67609] Deduplicate help button question mark"
+        message: |-
+          Set the question mark on the new help button only once so that it is not shown twice when using different themes.
+      - type: bug


9 rfe and 6 bug type entries, let's try to display them alternately.

I need to discuss the concept of "alternating" with Daniel Beck to assure that I understand his intention there. We've been grouping rfe as one group and bug as another group most recently and it may be time that I understand the intent of the alternation comment in the style guide. Thanks for the reminder!

@MarkEWaite Any updates on this?

jenkins-infra-changelog-generator bot requested a review from a team as a code owner February 9, 2022 13:56

probot-autolabeler bot added the changelog Jenkins changelogs label Feb 9, 2022

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch from 9ee710e to 00c09bc Compare February 9, 2022 17:24

MarkEWaite mentioned this pull request Feb 9, 2022

Changelog drafter on core fails with "string too long" jenkins-infra/helpdesk#2777

Closed

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch 5 times, most recently from e88ef3a to eb682df Compare February 9, 2022 18:06

infra-ci-jenkins-io bot deployed to preview February 9, 2022 21:01 View deployment

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch 2 times, most recently from ea78b17 to 7e851a3 Compare February 10, 2022 16:37

infra-ci-jenkins-io bot deployed to preview February 10, 2022 16:44 View deployment

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch from 7e851a3 to 5ec3844 Compare February 10, 2022 22:39

infra-ci-jenkins-io bot deployed to preview February 10, 2022 22:46 View deployment

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch from 5ec3844 to 9dbc039 Compare February 11, 2022 19:57

infra-ci-jenkins-io bot deployed to preview February 11, 2022 20:05 View deployment

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch 5 times, most recently from 1e14ae0 to 422a429 Compare February 12, 2022 15:45

infra-ci-jenkins-io bot deployed to preview February 12, 2022 15:55 View deployment

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch 2 times, most recently from 0184033 to 48dfcb1 Compare February 12, 2022 16:53

infra-ci-jenkins-io bot deployed to preview February 12, 2022 17:00 View deployment

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch 2 times, most recently from 092ec9b to f06ff91 Compare February 13, 2022 20:02

infra-ci-jenkins-io bot deployed to preview February 13, 2022 20:09 View deployment

dheerajodha reviewed Feb 14, 2022

View reviewed changes

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch 2 times, most recently from 4cc0ca9 to ea8cad4 Compare February 14, 2022 20:51

infra-ci-jenkins-io bot deployed to preview February 14, 2022 20:59 View deployment

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch from ea8cad4 to 9b03bf6 Compare February 15, 2022 02:15

infra-ci-jenkins-io bot deployed to preview February 15, 2022 02:21 View deployment

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch 3 times, most recently from 01d9bc9 to 476cd83 Compare February 15, 2022 04:04

infra-ci-jenkins-io bot deployed to preview February 15, 2022 04:12 View deployment

Automated changelog for 2.335

ac335ce

jenkins-infra-changelog-generator bot force-pushed the automated-weekly-changelog/2.335 branch from 476cd83 to ac335ce Compare February 15, 2022 19:29

infra-ci-jenkins-io bot deployed to preview February 15, 2022 19:37 View deployment

MarkEWaite approved these changes Feb 16, 2022

View reviewed changes

MarkEWaite merged commit a8e7a4b into master Feb 16, 2022

MarkEWaite deleted the automated-weekly-changelog/2.335 branch February 16, 2022 19:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automated changelog for 2.335 #4909

Automated changelog for 2.335 #4909

jenkins-infra-changelog-generator bot commented Feb 9, 2022

dheerajodha left a comment

dheerajodha Feb 14, 2022

MarkEWaite Feb 15, 2022

dheerajodha Feb 14, 2022

MarkEWaite Feb 15, 2022 •

edited

Loading

dheerajodha Feb 14, 2022

MarkEWaite Feb 15, 2022

dheerajodha Feb 14, 2022

MarkEWaite Feb 15, 2022

dheerajodha Feb 14, 2022

MarkEWaite Feb 15, 2022

dheerajodha left a comment

dheerajodha Feb 14, 2022

MarkEWaite Feb 15, 2022 •

edited

Loading

dheerajodha Feb 14, 2022

MarkEWaite Feb 15, 2022

dheerajodha Feb 14, 2022

MarkEWaite Feb 15, 2022

dheerajodha Feb 14, 2022

MarkEWaite Feb 15, 2022

dheerajodha Feb 21, 2022

	Replace computer-flash gif icon with hourglass
	Replace the computer-flash GIF icon with the hourglass icon.

	Remove support for <code>RoleChecker#check(RoleSensitive)</code> calls added in Jenkins 2.319 again. All remoting <code>Callable</code> implementations need to perform an actual role check as documented at https://www.jenkins.io/doc/developer/security/remoting-callables/
	Remove support for <code>RoleChecker#check(RoleSensitive)</code> calls which were added again in Jenkins 2.319. All remoting <code>Callable</code> implementations need to perform an actual role check as documented at https://www.jenkins.io/doc/developer/security/remoting-callables/

	Several icons across Jenkins have been updated - the build icon, the delete icon, the settings icon, the about icon and the plugin icon
	Several icons across Jenkins have been updated - the build icon, the delete icon, the settings icon, the about icon, and the plugin icon.

	Minor form and spacing changes
	Minor form and spacing changes.

	Set the question mark on the new help button only once so that it is not shown twice when using different themes.
	Render the question mark on the new help button only once, even while using different themes.

Automated changelog for 2.335 #4909

Automated changelog for 2.335 #4909

Conversation

jenkins-infra-changelog-generator bot commented Feb 9, 2022

dheerajodha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarkEWaite Feb 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dheerajodha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarkEWaite Feb 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarkEWaite Feb 15, 2022 •

edited

Loading

MarkEWaite Feb 15, 2022 •

edited

Loading