IG Importer doesn't load #312
Conversation
Bug fixes
|
Task linked: CU-86byxfvwm IG Importer doesn't load |
WalkthroughThe changes involve updates to various configuration files for improved system integration, particularly focusing on adding new environment variables for Kafka, OpenHIM, Nginx, and other services. Notable updates include enhancements to handling CORS requests in Nginx, changing the FHIR IG Importer URL to a cloud-based endpoint, and configuring settings in Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Nginx
participant OpenHIM
participant Microservice
User->>Nginx: Send Request
alt OPTIONS Request
Nginx->>Nginx: Handle CORS
Nginx-->>User: Respond with 204
else Other Requests
Nginx->>OpenHIM: Proxy to OpenHIM
OpenHIM->>Microservice: Forward request
Microservice->>OpenHIM: Response
OpenHIM->>Nginx: Proxy response
Nginx->>User: Send Response
end
Tip AI model upgrade
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- .env.local (1 hunks)
- fhir-ig-importer/importer/volume/ig-importer-app.json (1 hunks)
- fhir-ig-importer/package-metadata.json (1 hunks)
- interoperability-layer-openhim/docker-compose.yml (1 hunks)
- interoperability-layer-openhim/package-metadata.json (1 hunks)
- reverse-proxy-nginx/package-conf-secure/http-openhim-secure.conf (1 hunks)
Files skipped from review due to trivial changes (2)
- fhir-ig-importer/importer/volume/ig-importer-app.json
- fhir-ig-importer/package-metadata.json
Additional context used
Gitleaks
interoperability-layer-openhim/package-metadata.json
43-43: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Additional comments not posted (7)
.env.local (4)
29-30: Verify OpenHIM configuration.The new variables
OPENHIM_CORE_MEDIATOR_HOSTNAMEandOPENHIM_MEDIATOR_API_PORTare added. Ensure these values are correct and accessible.Verification successful
OpenHIM configuration verified.
The hostname
openhimcomms.platform.jembi.cloudand port443are accessible, as indicated by theHTTP/1.1 401 Unauthorizedresponse, which confirms that the server is reachable.
.env.locallines 29-30Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify OpenHIM configuration. # Test: Check if OpenHIM core mediator hostname and API port are accessible. curl -I https://openhimcomms.platform.jembi.cloud:443Length of output: 790
Script:
#!/bin/bash # Description: Verify OpenHIM configuration without SSL verification. # Test: Check if OpenHIM core mediator hostname and API port are accessible without SSL verification. curl -Ik https://openhimcomms.platform.jembi.cloud:443Length of output: 570
27-27: Ensure Kafka topics are correctly configured.The new Kafka topics include
2xx-async,patient, andobservation. Verify that these topics are correctly set up in the Kafka broker.Verification successful
Kafka topics are correctly configured.
The
.envfiles confirm the presence of the Kafka topics2xx-async,patient, andobservationalong with other topics.
cdr.envcdr-dw.envScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify Kafka topics configuration in the Kafka broker. # Test: List Kafka topics. Expect: Topics include 2xx-async, patient, observation. kafka-topics.sh --list --bootstrap-server localhost:9092Length of output: 141
Script:
#!/bin/bash # Searching for Kafka topics configuration in the codebase. rg --fixed-strings '2xx-async' --files-with-matches rg --fixed-strings 'patient' --files-with-matches rg --fixed-strings 'observation' --files-with-matchesLength of output: 2149
Script:
#!/bin/bash # Display the contents of the relevant .env files to verify Kafka topics configuration. cat cdr.env cat cdr-dw.envLength of output: 1271
47-51: Verify service URLs configuration.The new service URLs include
REACT_APP_JEMPI_BASE_API_HOST,REACT_APP_JEMPI_BASE_API_PORT,OPENHIM_CONSOLE_BASE_URL,OPENHIM_API_HOST, andOPENHIM_API_PORT. Ensure these URLs and ports are correct and accessible.
33-35: Verify Nginx reverse proxy settings.The new variables
REVERSE_PROXY_INSTANCES,DOMAIN_NAME, andSUBDOMAINSare added. Ensure these values are correctly set for the Nginx reverse proxy.Verification successful
Nginx reverse proxy settings are correctly configured.
The domains and subdomains are correctly listed in the
.env.localfile, and the file is referenced in various setup scripts, ensuring the Nginx reverse proxy settings are applied as intended.
.env.localcontains the required domain and subdomain configurations.- The
.env.localfile is referenced in multiple setup scripts, confirming its usage in the configuration process.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify Nginx reverse proxy settings. # Test: Check if the domain and subdomains are correctly configured in Nginx. nginx -T | grep -E 'platform.jembi.cloud|openhimcomms.platform.jembi.cloud'Length of output: 150
Script:
#!/bin/bash # Description: Verify Nginx reverse proxy settings in configuration files. # Test: Search for domain and subdomains in Nginx configuration files. fd -e conf -e nginx | xargs grep -E 'platform.jembi.cloud|openhimcomms.platform.jembi.cloud'Length of output: 94
Script:
#!/bin/bash # Description: Verify Nginx reverse proxy settings and .env.local references. # Test 1: Search for domain and subdomains in all files. grep -rE 'platform.jembi.cloud|openhimcomms.platform.jembi.cloud' . # Test 2: Search for references to .env.local in the codebase. grep -r '.env.local' .Length of output: 7795
interoperability-layer-openhim/package-metadata.json (2)
46-46: VerifyOPENHIM_CONSOLE_BASE_URLconfiguration.The new variable
OPENHIM_CONSOLE_BASE_URLis added. Ensure this value is correct and accessible.
47-48: Verify OpenHIM API host and port configuration.The new variables
OPENHIM_API_HOSTandOPENHIM_API_PORTare added. Ensure these values are correct and accessible.reverse-proxy-nginx/package-conf-secure/http-openhim-secure.conf (1)
62-71: Review newOPTIONSblock for CORS handling.The new block handles
OPTIONSrequests by adding CORS headers and returning a204status code. Ensure this block is correctly implemented.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .env.remote (1 hunks)
Additional comments not posted (7)
.env.remote (7)
3-3: Verify the clustered mode change.The
CLUSTERED_MODEis set tofalse. Ensure that this change is intentional and aligns with the deployment strategy.
7-9: Verify the logging configuration.The
DEBUGis set to0,BASHLOG_FILEis set to0, andBASHLOG_FILE_PATHis set toplatform.log. Ensure that these settings meet the operational requirements.
13-14: Verify the Logstash configuration.The
LOGSTASH_DEV_MOUNTis set tofalse, andLOGSTASH_PACKAGE_PATHis empty. Ensure that Logstash is configured correctly.
19-20: Verify the JS Report configuration.The
JS_REPORT_DEV_MOUNTis set tofalse, andJS_REPORT_PACKAGE_PATHis empty. Ensure that JS Report is configured correctly.
27-27: Verify the Kafka topics configuration.The
KAFKA_TOPICSis set to2xx,2xx-async,reprocess,3xx,metrics:3:3,patient,observation. Ensure that these topics are correctly configured with the necessary partitions and replication factors.
33-35: Verify the reverse proxy configuration.The
REVERSE_PROXY_INSTANCESis set to1,DOMAIN_NAMEis set to<domain>, andSUBDOMAINSis set to a list of subdomains. Ensure that these settings are correct.
40-51: Verify the URLs for IAM and related services.The URLs for Keycloak, Grafana, Jempi, Superset, and OpenHIM are set. Ensure that these URLs are correct and accessible.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .env.remote (1 hunks)
Additional comments not posted (7)
.env.remote (7)
3-3: Verify the impact of settingCLUSTERED_MODEtofalse.Ensure this change aligns with the intended deployment strategy and does not affect the application's performance or availability.
7-9: Verify the logging configurations.Ensure the
DEBUG,BASHLOG_FILE, andBASHLOG_FILE_PATHvariables are set correctly for the intended environment.
13-14: Verify the Logstash configurations.Ensure the
LOGSTASH_DEV_MOUNTandLOGSTASH_PACKAGE_PATHvariables are set correctly and the paths are valid.
19-20: Verify the JS Report configurations.Ensure the
JS_REPORT_DEV_MOUNTandJS_REPORT_PACKAGE_PATHvariables are set correctly and the paths are valid.
27-27: Verify the Kafka topics configuration.Ensure the
KAFKA_TOPICSvariable is correctly configured and matches the application's requirements.
33-35: Verify the Nginx reverse proxy configurations.Ensure the
REVERSE_PROXY_INSTANCES,DOMAIN_NAME, andSUBDOMAINSvariables are set correctly and the domain names are valid.
40-51: Verify the Keycloak and related services configurations.Ensure the Keycloak and related services variables (
KC_FRONTEND_URL,KC_GRAFANA_ROOT_URL,KC_JEMPI_ROOT_URL,KC_SUPERSET_ROOT_URL,KC_OPENHIM_ROOT_URL,GF_SERVER_DOMAIN,REACT_APP_JEMPI_BASE_API_HOST,REACT_APP_JEMPI_BASE_API_PORT,OPENHIM_CONSOLE_BASE_URL,OPENHIM_API_HOST,OPENHIM_API_PORT) are set correctly and the URLs are valid.
drizzentic
force-pushed
the
CU-86byxfvwm_IG-Importer-doesnt-load
branch
from
b5cfba8
to
94c734b
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- fhir-ig-importer/importer/volume/ig-importer-app.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- fhir-ig-importer/importer/volume/ig-importer-app.json
Bug fixes
Summary by CodeRabbit
New Features
Improvements
OPTIONSrequests in Nginx reverse proxy configuration.Configuration Changes
.envfiles to include various service endpoints and ports.CLUSTERED_MODEsetting in.env.remotefor optimized system integration and access control.