Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IP whitelist authorisation #1157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cozej4
Copy link

@cozej4 cozej4 commented Nov 5, 2021

From the Documentation.

Whitelisted IP Addresses - A list of IP addresses that will be given access without authentication required.

Fixed issues in authorizing requests from whitelisted IP which should not require additional Client Authorisation

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1157 (a4356c3) into master (999047c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
- Coverage   85.02%   85.00%   -0.02%     
==========================================
  Files          77       77              
  Lines        5247     5247              
==========================================
- Hits         4461     4460       -1     
- Misses        786      787       +1     
Impacted Files Coverage Δ
src/middleware/authorisation.js 100.00% <100.00%> (ø)
src/middleware/messageStore.js 89.60% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999047c...a4356c3. Read the comment docs.

@MattyJ007
Copy link
Contributor

Thanks for the contribution @cozej4 💯
We will review this as soon as we can.

@cozej4
Copy link
Author

cozej4 commented Nov 10, 2021

Thanks for the contribution @cozej4 💯 We will review this as soon as we can.

Thanks @MattyJ007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants