Cu 86c11rv16 automated tests #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brett-onions
commented
Nov 21, 2024
brett-onions
commented
- allows for the listening to multiple buckets
- updated GitHub action to use docker compose file for testing
- merging with s3 data insertion
drizzentic
reviewed
Nov 22, 2024
marvinIsSacul
requested changes
Nov 22, 2024
marvinIsSacul
requested changes
Nov 22, 2024
|
|
||
| try { | ||
| //@ts-ignore | ||
| minioClient.fGetObject(bucket, file, `tmp/${file}`, async (err) => { |
There was a problem hiding this comment.
see if you can use Promises consistently. Instead of using this callback intertwined with other promises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.