remove the execution of the scala generation script #255
Conversation
|
Task linked: CU-86byyt9uc Fix CI Build |
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
JeMPI_Apps/build-all-ci.sh (4)
Line range hint
13-13: Consider using-ninstead of! -zfor string non-empty check for better readability.- if [ ! -z "$tag_to_use" ]; then + if [ -n "$tag_to_use" ]; then
Line range hint
14-14: Useread -rto prevent mangling of backslashes.- IFS=':' read -a image_details <<< "$2" + IFS=':' read -ra image_details <<< "$2"
Line range hint
15-17: Ensure all variables are double-quoted to prevent globbing and word splitting.- docker tag $1 ${image_details[0]}:$tag_to_use + docker tag "$1" "${image_details[0]}:$tag_to_use"
Line range hint
29-61: Ensure all variables indocker tagcommands are double-quoted to prevent globbing and word splitting.- tag_image $ASYNC_RECEIVER_IMAGE $ASYNC_RECEIVER_HUB_IMAGE + tag_image "$ASYNC_RECEIVER_IMAGE" "$ASYNC_RECEIVER_HUB_IMAGE" - tag_image $ETL_IMAGE $ETL_HUB_IMAGE + tag_image "$ETL_IMAGE" "$ETL_HUB_IMAGE" - tag_image $CONTROLLER_IMAGE $CONTROLLER_HUB_IMAGE + tag_image "$CONTROLLER_IMAGE" "$CONTROLLER_HUB_IMAGE" - tag_image $EM_SCALA_IMAGE $EM_SCALA_HUB_IMAGE + tag_image "$EM_SCALA_IMAGE" "$EM_SCALA_HUB_IMAGE" - tag_image $LINKER_IMAGE $LINKER_HUB_IMAGE + tag_image "$LINKER_IMAGE" "$LINKER_HUB_IMAGE" - tag_image $API_IMAGE $API_HUB_IMAGE + tag_image "$API_IMAGE" "$API_HUB_IMAGE" - tag_image $API_KC_IMAGE $API_KC_HUB_IMAGE + tag_image "$API_KC_IMAGE" "$API_KC_HUB_IMAGE" - tag_image $BOOTSTRAPPER_IMAGE $BOOTSTRAPPER_HUB_IMAGE + tag_image "$BOOTSTRAPPER_IMAGE" "$BOOTSTRAPPER_HUB_IMAGE" - tag_image $UI_IMAGE $UI_HUB_IMAGE + tag_image "$UI_IMAGE" "$UI_HUB_IMAGE"
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- JeMPI_Apps/build-all-ci.sh (1 hunks)
Additional Context Used
ShellCheck (25)
JeMPI_Apps/build-all-ci.sh (25)
[style] 13-13: Use -n instead of ! -z.
[info] 14-14: read without -r will mangle backslashes.
[info] 15-15: Double quote to prevent globbing and word splitting.
[info] 15-15: Double quote to prevent globbing and word splitting.
[info] 15-15: Double quote to prevent globbing and word splitting.
[info] 17-17: Double quote to prevent globbing and word splitting.
[info] 17-17: Double quote to prevent globbing and word splitting.
[info] 29-29: Double quote to prevent globbing and word splitting.
[info] 29-29: Double quote to prevent globbing and word splitting.
[info] 33-33: Double quote to prevent globbing and word splitting.
[info] 33-33: Double quote to prevent globbing and word splitting.
[info] 37-37: Double quote to prevent globbing and word splitting.
[info] 37-37: Double quote to prevent globbing and word splitting.
[info] 41-41: Double quote to prevent globbing and word splitting.
[info] 41-41: Double quote to prevent globbing and word splitting.
[info] 45-45: Double quote to prevent globbing and word splitting.
[info] 45-45: Double quote to prevent globbing and word splitting.
[info] 49-49: Double quote to prevent globbing and word splitting.
[info] 49-49: Double quote to prevent globbing and word splitting.
[info] 53-53: Double quote to prevent globbing and word splitting.
[info] 53-53: Double quote to prevent globbing and word splitting.
[info] 57-57: Double quote to prevent globbing and word splitting.
[info] 57-57: Double quote to prevent globbing and word splitting.
[info] 61-61: Double quote to prevent globbing and word splitting.
[info] 61-61: Double quote to prevent globbing and word splitting.
Summary by CodeRabbit