New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jempi base windows #133

Merged

MatthewErispe merged 9 commits into dev from jempi-base-windows

Oct 29, 2023

Collaborator

w-hayes commented Oct 23, 2023

windows environment fixes

w-hayes added 6 commits

October 20, 2023 13:23


          devops - base-docker-wsl

4d6246f


          partial devops windows

5d57abd


          partial devops windows

7a7324f


          partial devops windows

cea66f7


          Saving files before refreshing line endings

480dadb


          scala generate line endings for environment

ad27c61

walisc self-requested a review

October 23, 2023 07:52

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/conf/env/conf-env-high-1-pc.template Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/a-images-1-pull-from-hub.sh Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/conf/env/conf-env-high-1-pc.template Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/conf/env/conf-env-low-1-pc.template Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/conf/images/conf-hub-images.sh Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/docker-stack.yml Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/docker-stack.yml Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/docker-stack.yml Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/helper/log/logs-jempi-input-disi.sh Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/helper/log/logs-jempi-api-kc.sh Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/helper/log/logs-zookeeper.sh Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/helper/log/logs-lambda.sh Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/base-docker-wsl/helper/scripts/d-stack-09-wait-removed.sh Outdated Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/run--base-docker-linux/start.ps1 Show resolved Hide resolved

walisc reviewed

View reviewed changes

devops/windows/run--base-docker-wsl/start.ps1 Show resolved Hide resolved

Collaborator

walisc commented Oct 23, 2023

Hi @w-hayes . Thanks for this! Have added my comments above. p.s I know we said we will need to rewrite the whole readme file for JeMPI, but for now could we add some basic instruction of how to get it running on windows (for posterity/so that others are aware) . Thanks @w-hayes !

MatthewErispe changed the base branch from jempi-base to dev

October 26, 2023 09:50

MatthewErispe added 3 commits

October 26, 2023 11:51


          Merge branch 'dev' into jempi-base-windows

56d71b3


          Merge branch 'dev' into jempi-base-windows

0c5028b


          address code review comments

6b2095a

MatthewErispe approved these changes

View reviewed changes

Collaborator

MatthewErispe left a comment

@walisc I addressed all your comments. The only change pending is the readme for the windows setup steps. This will be done in a separate branch/pr

MatthewErispe merged commit e81ee67 into dev

MatthewErispe deleted the jempi-base-windows branch

October 29, 2023 08:40

Collaborator

walisc commented Oct 30, 2023

@walisc I addressed all your comments. The only change pending is the readme for the windows setup steps. This will be done in a separate branch/pr

Thanks for this @MatthewErispe ! Sorry you had to sacrifice some of your weekend for this 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet