This repository was archived by the owner on Aug 24, 2022. It is now read-only.
replace share method with singleton method for laravel 5.4 #31
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, did they change it for Laravel 4 as well, because I see that you have modified the Laravel4ServiceProvider as well? |
|
No problem, From the looks of the docs it was only removed in laravel 5.4 so the modification to Laravel4ServiceProvider can be removed/ignored. |
|
Is this on master? I'm still getting this error. i.e. share() |
|
@mbarwick83 no it is not yet, I will test this weekend and merge into master. For now I suggest you use the TeeeeJaaaaY fork. |
|
Finally got the time to test this, was singleton introduced from 5.4 or was it available in previous 5.* versions as well? |
|
Its available in 5* |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #30