Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content hash to CSS files #6282

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Add content hash to CSS files #6282

merged 1 commit into from
Nov 1, 2024

Conversation

viown
Copy link
Member

@viown viown commented Nov 1, 2024 •
edited
Loading

Changes
Add a content hash to CSS files to prevent caching issues

Issues

@viown viown requested a review from a team as a code owner November 1, 2024 00:57
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 1, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 89b5e44
Status ✅ Deployed!
Preview URL https://54d0b297.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

nielsvanvelzen
nielsvanvelzen approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix the issue, network inspector shows the loaded CSS files now have hashes in the name.

Can you change the target branch to release-10.10.z and add the "stable backport" label?

@viown viown force-pushed the add-hash-to-filenames branch from e7e4725 to 89b5e44 Compare November 1, 2024 08:35
@viown viown changed the base branch from master to release-10.10.z November 1, 2024 08:35
@viown viown added the stable backport Backport into the next stable release label Nov 1, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@thornbill thornbill added the bug Something isn't working label Nov 1, 2024
@thornbill thornbill added this to the v10.10.1 milestone Nov 1, 2024
@thornbill thornbill merged commit d365dd1 into jellyfin:release-10.10.z Nov 1, 2024
14 checks passed
@viown viown deleted the add-hash-to-filenames branch November 1, 2024 20:53
joshuaboniface pushed a commit that referenced this pull request Nov 3, 2024
@viown @joshuaboniface
Backport pull request #6282 from jellyfin-web/release-10.10.z
8a6491d 
Add content hash to CSS files

Original-merge: d365dd1

Merged-by: thornbill <[email protected]>

Backported-by: Joshua M. Boniface <[email protected]>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Nov 3, 2024
@viown viown mentioned this pull request Nov 3, 2024
Closed
5 tasks
kevgrig pushed a commit to kevgrig/jellyfin-web that referenced this pull request Jan 7, 2025
@viown @kevgrig
Backport pull request jellyfin#6282 from jellyfin-web/release-10.10.z
2c16fe9 
Add content hash to CSS files

Original-merge: d365dd1

Merged-by: thornbill <[email protected]>

Backported-by: Joshua M. Boniface <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@viown @jellyfin-bot @nielsvanvelzen @thornbill