Only connect to ServerConnections once #6150
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
viown
force-pushed
the
fix-dashboard-theming
branch
2 times, most recently
from
1428d79
to
32e078b
Compare
viown
force-pushed
the
fix-dashboard-theming
branch
from
32e078b
to
557eea5
Compare
viown
force-pushed
the
fix-dashboard-theming
branch
from
557eea5
to
d580429
Compare
|
|
There is an issue where if you try to login after refreshing the login page it won't redirect you (this existed prior to this PR, even in 10.9), so might as well fix it here. |
Cloudflare Pages deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the client will send a request to
ServerConnections.connectevery time we switch pages. With this, the behaviour should now be the same as prior to app routing being removed.Changes
Change it so that we only connect to ServerConnections once with each session, reducing unnecessary calls to
/System/Info/Publicwith each navigation.Issues
Fixes #6143