Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependencies #434

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

thornbill
Copy link
Member

Updates a bunch of imports and moves some constants to dedicated files to avoid circular dependencies

Fixes #425

@thornbill thornbill added the cleanup Cleanup of legacy code or code smells label Mar 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #434 (d00c378) into master (0c55c31) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          78       80    +2     
  Lines         483      488    +5     
  Branches       48       48           
=======================================
+ Hits          482      487    +5     
  Misses          1        1           
Impacted Files Coverage Δ
src/discovery/discovery-service.ts 100.00% <100.00%> (ø)
src/discovery/recommended-server-discovery.ts 100.00% <100.00%> (ø)
src/jellyfin.ts 100.00% <100.00%> (ø)
src/utils/url/constants.ts 100.00% <100.00%> (ø)
src/utils/url/index.ts 100.00% <100.00%> (ø)
src/utils/url/normalize-url.ts 100.00% <100.00%> (ø)
src/versions.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/versions.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.5% 3.5% Duplication

@thornbill thornbill merged commit 341e25e into jellyfin:master Mar 24, 2023
@thornbill thornbill deleted the round-and-round branch March 24, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix circular dependencies
3 participants