Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import order warnings #298

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Conversation

thornbill
Copy link
Member

Fixes all warnings for import order and makes them errors going forward

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #298 (c49fd65) into master (db76985) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   32.95%   32.95%           
=======================================
  Files          37       37           
  Lines         701      701           
  Branches      136      136           
=======================================
  Hits          231      231           
  Misses        425      425           
  Partials       45       45           
Impacted Files Coverage Δ
components/AppInfoFooter.js 100.00% <ø> (ø)
components/BrowserListItem.js 100.00% <ø> (ø)
components/ButtonListItem.js 100.00% <ø> (ø)
components/RefreshWebView.js 0.00% <ø> (ø)
components/ServerListItem.js 100.00% <ø> (ø)
components/SwitchListItem.js 100.00% <ø> (ø)
components/VideoPlayer.js 0.00% <ø> (ø)
i18n.js 100.00% <ø> (ø)
navigation/HomeNavigator.js 0.00% <ø> (ø)
navigation/TabNavigator.js 0.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db76985...c49fd65. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anthonylavado anthonylavado merged commit e5cd7a5 into jellyfin:master Oct 7, 2021
@thornbill thornbill deleted the fix-import-order branch October 7, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants